Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem removing group with long names #1407

Closed
juniorcaemj opened this issue May 17, 2016 · 7 comments
Closed

Problem removing group with long names #1407

juniorcaemj opened this issue May 17, 2016 · 7 comments

Comments

@juniorcaemj
Copy link

JabRef version 3.2 on Windows 10

User Interface Problem

If a group with a long name been removed, the JOptionPane box is created too large, vanishing "Yes" and "No" buttons.

Steps to reproduce:

  1. Create a group with a long name
  2. Try remove group

1
2

@matthiasgeiger
Copy link
Member

Thanks for your report.

If this is a real problem for you, simply delete the group just hit "enter" as "Yes" is preselected.

However, this seems to be only a theoretical problem, so we might fix this in a later version but first concentrate on other more important aspects.

@juniorcaemj
Copy link
Author

Hello @matthiasgeiger, I report this problem because it's a work (especifically UI Tests) for a Software Testing course, and we utilize JabRef as a case study. So I found interesting report it to the community.

@simonharrer
Copy link
Contributor

Thanks for the info. We welcome that JabRef is used in testing case studies. 👍

What would be the expect solution? Truncate the group name after a specific number of letters?

We also have UI tests in place at https://github.com/JabRef/jabref/tree/master/src/integrationTest/java/net/sf/jabref/gui - you could also have a look there. They are only the tip of the iceberg, and need further improvements. :)

@matthiasgeiger
Copy link
Member

Nice to hear, that JabRef is used in a practical Software Testing course. 👍

Hopefully not only as a bad example 😉 We already know that the test coverage of our code should be improved, and we are already working on it. But especially on the field of UI testing there are only a few tests present - as Simon just mentioned.

If you are implementing practical, executable tests in your course we'd love to integrate them into our tests - if this is possible!

If you have other findings, or tips for us to improve JabRef just contact us!

@juniorcaemj
Copy link
Author

@simonharrer I thinking in this solution too, limit the size of group name, doesn't make any sense a group with a very very long name..

@matthiasgeiger I will read the documentation and submit my tests (and maybe a solution), as soon as I can.

@oscargus oscargus added the groups label Aug 2, 2016
@stefan-kolb
Copy link
Member

I just tried this and it's really a theoretical problem because the message box is just sized as big as the group name. If you move the mbox or you have two monitors it's still there for you. This is such a small improvement and will probably never happen so that we defer it to the UI rework.

@tobiasdiez tobiasdiez reopened this Feb 24, 2017
tobiasdiez added a commit that referenced this issue Feb 24, 2017
Issue #1407 is fixed in the process
tobiasdiez added a commit that referenced this issue Mar 3, 2017
* Add "Remove group and subgroups" option
Issue #1407 is fixed in the process

* Remove old code

* Implement #1904: filter groups

* Entries are filtered again correctly
@tobiasdiez
Copy link
Member

This should be fixed in the latest development version. Could you please check the build from http://builds.jabref.org/master/. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants