Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reference to old "pdfDirectory" in the code #1798

Closed
oscargus opened this issue Aug 20, 2016 · 3 comments
Closed

Reference to old "pdfDirectory" in the code #1798

oscargus opened this issue Aug 20, 2016 · 3 comments
Labels
[outdated] type: bug Confirmed bugs or reports that are very likely to be bugs [outdated] type: enhancement
Milestone

Comments

@oscargus
Copy link
Contributor

In UrlDragDrop there is the following piece of code:

                        //auto filename:
                        File file = new File(new File(Globals.prefs.get("pdfDirectory")),
                                editor.getEntry().getCiteKey() + ".pdf");
                        frame.output(Localization.lang("Downloading..."));

This should be changed to use, if nothing else, the correct directory and preferably the correct file name.

@oscargus oscargus added [outdated] type: bug Confirmed bugs or reports that are very likely to be bugs [outdated] type: enhancement labels Aug 20, 2016
@stefan-kolb stefan-kolb added this to the v3.6 milestone Aug 21, 2016
@stefan-kolb
Copy link
Member

stefan-kolb commented Aug 22, 2016

UrlDragDrop .java is never used in current master?! Only SimpleUrlDragDrop.java.

@stefan-kolb
Copy link
Member

See #1454, #121

@stefan-kolb
Copy link
Member

Also, the FieldProperties.URL seems to be never used at the moment.

        } else if (fieldExtras.contains(FieldProperties.URL)) {
            return FieldExtraComponents.getURLExtraComponent(editor, getStoreFieldAction());

stefan-kolb added a commit that referenced this issue Aug 23, 2016
Resolves #1798 Remove unused DragAndDrop Handlers and URL extra field…
ayanai1 pushed a commit to ayanai1/jabref that referenced this issue Sep 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[outdated] type: bug Confirmed bugs or reports that are very likely to be bugs [outdated] type: enhancement
Projects
None yet
Development

No branches or pull requests

2 participants