Search field is persistent over tab switch

[rfgiusti]

JabRef version 3.8.1 on Debian GNU/Linux stretch/sid with JRE OpenJDK 1.8.0_111 and Xfce 4.12.

Description after performing a search and cleaning the search field, switching to another tab and back will reinsert the search query.

Steps to reproduce

1. Create two empty databases (they need not be empty, but this seems the easiest path to reproduce the error);
2. Press CTRL+F and search for anything on the first database;
3. Erase the contents of the search field (either by deleting, pressing ESC or clicking on the X button);
4. Switch to the second database;
5. Switch back to the first database.

Expected behavior: the first database should be displayed normally and the search field is empty;
Actual behavior: the first database shows the results of the search and the search field contains the deleted query terms.

[koppor]

Try to uncheck the icon showing the earth. Does that work for you?

[rfgiusti]

The icon is not checked. The issue happens when I come back to the tab where I did the search. Interestingly though, if I do check the icon, after I uncheck it all tabs behave as if they are in search mode (even after deleting the query from each of them).

[koppor]

@bartsch-dev Can you comment on that?

[chriba]

I think I know the problem, looking into it right now.

[chriba]

This Issue is fixed in the current master, you can download the development version here https://builds.jabref.org/master or wait for the next release.

[rfgiusti]

Checked from master; looks good!

But there's also the secondary behavior that I noticed after koppor's comment: when you make a global search, it seems to create one search query for each tab. If you uncheck global search before deleting the query, there will remain one search query associated with each tab.

Should I open another issue?