Save deletion of current searchquery #2469
Conversation
| @@ -207,7 +207,8 @@ | |||
|
|
|||
| private ContentAutoCompleters autoCompleters; | |||
|
|
|||
| private SearchQuery currentSearchQuery; | |||
| /** the query the user searches when this basepanel is active */ | |||
There was a problem hiding this comment.
Please use // as comment for fields. (Or quote some manual where block comments are recommended)
There was a problem hiding this comment.
JavaDoc works on properties too (I think you overlooked the second asterisks).
| public void setCurrentSearchQuery(SearchQuery currentSearchQuery) { | ||
| this.currentSearchQuery = currentSearchQuery; | ||
| if (currentSearchQuery == null) { |
There was a problem hiding this comment.
You can use Optional.ofNullable(currentSearchQuery) instead of this if/else block
There was a problem hiding this comment.
However, I am unsure whether trim().isEmpty() should be checked for. I think, your current code is OK. (After the usage of ofNullable.
| @@ -19,6 +19,7 @@ We refer to [GitHub issues](https://github.com/JabRef/jabref/issues) by using `# | |||
| - Non-ISO timestamp settings prevented the opening of the entry editor (see [#2447](https://github.com/JabRef/jabref/issues/2447)) | |||
| - When pressing <kbd>Ctrl</kbd> + <kbd>F</kbd> and the searchbar is already focused the text will be selected. | |||
| - LaTeX symbols are now displayed as Unicode for the author column in the main table. "'n" and "\'{n}" are parsed correctly. Fixes [#2458](https://github.com/JabRef/jabref/issues/2458). | |||
| - Fixes [#2468](https://github.com/JabRef/jabref/issues/2468): Save deletion of current searchquery. | |||
There was a problem hiding this comment.
I would use (a slight update of) your long sentence of the PR text here - and put the "Fixes" as last (as with the other entries)
If one deleted the current query, it was not saved (every database can have its own query). Fixes #2468.
* upstream/master: Save deletion of current searchquery (#2469) Update dev dependencies (mockito, wiremock, assertj) Update BouncyCastle (1.55->1.56), ANTRL4 (4.5.3->4.6), jsoup (1.10.1->1.10.2) Group all checker which only check the value of one field (#2437) Follow up #2428 (#2438) Fix conversion of "'n" and "\'{n}" from LaTeX to Unicode (#2464) Fix failing tests
Fixes #2468.
If one deleted the current query it was not saved (every basepanel can have it's own query).
The only neede change is the line in
GlobalSearchBar.java.gradle localizationUpdate?