Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes in Source Tab are not saved correctly without switching to another tab #3086

Closed
Doc73 opened this issue Aug 8, 2017 · 18 comments · Fixed by #3097
Closed

Changes in Source Tab are not saved correctly without switching to another tab #3086

Doc73 opened this issue Aug 8, 2017 · 18 comments · Fixed by #3097
Labels
bug Confirmed bugs or reports that are very likely to be bugs entry-editor
Milestone

Comments

@Doc73
Copy link
Contributor

Doc73 commented Aug 8, 2017

JabRef version 4.0-beta2 on Debian 9 Stretch AMD64

Steps to reproduce:

  1. Add a book entry
  2. Add title, author etc. and save
  3. Add subtitle and save
  4. Switch to another entry
  5. Return to the previous entry --> subtitle disappeared!!!!

It is very annoying and happens also with other fields.

@koppor koppor added this to the v4.0 milestone Aug 8, 2017
@koppor koppor added bug Confirmed bugs or reports that are very likely to be bugs entry-editor labels Aug 8, 2017
@koppor
Copy link
Member

koppor commented Aug 8, 2017

Which java version? Did you try our latest build? You can also try snap install jabref --edge --devmode. - snapd should be available at Debian testing.

@matthiasgeiger
Copy link
Member

Hi @Doc73,
I cannot reproduce the problem on my machine with your description neither using the 4.0-beta2 nor using the most recent dev builds...

Can you please check whether this problem is also present in the dev builds available from https://builds.jabref.org/master ?

@matthiasgeiger matthiasgeiger added status: waiting-for-feedback The submitter or other users need to provide more information about the issue and removed bug Confirmed bugs or reports that are very likely to be bugs labels Aug 8, 2017
@Doc73
Copy link
Contributor Author

Doc73 commented Aug 8, 2017

Dear all,
I use latest openjdk-jre version available in Debian Stable repositories, i. e. 8u141-b15-1~deb9u1, with openjfx v. 8u111-b14-1.

I can reproduce it sistematically with beta2. Try this way:

  1. Add a book with author, title, date, key
  2. Search the item with a field common to other items, in order to have other items in table with the one just added.
  3. In biblatex source editor, add ex. gr. titleaddon
  4. In the table, switch with arrows to another item
  5. Return to previous item

Later I'll try dev builds.

EDIT
From other tests, it seems that the issue happens whenever I add an entry in source editor.

@Doc73
Copy link
Contributor Author

Doc73 commented Aug 8, 2017

I can confirm that the real issue is that every changes made directly into the source editor are not saved, even if you press the CTRL+S keys. :-(

@matthiasgeiger
Copy link
Member

matthiasgeiger commented Aug 8, 2017

Thanks for the clarification.

I can now reproduce the problem in 4.0-beta2 and master: Changes in the source tab are not stored when switching to another entry.
However, if you switch to another tab first before selecting another entry this problem does not happen. This might be a workaround for you.

Potentially related to #2946 resp. 03861a3 - @tobiasdiez can you check whether this is easily solvable?

//Edit: Also related #3063

Best regards,
Matthias

@matthiasgeiger matthiasgeiger added bug Confirmed bugs or reports that are very likely to be bugs and removed status: waiting-for-feedback The submitter or other users need to provide more information about the issue labels Aug 8, 2017
@matthiasgeiger matthiasgeiger changed the title Disappearing fields Changes in Source Tab are not saved correctly without switching to another tab Aug 8, 2017
@Doc73
Copy link
Contributor Author

Doc73 commented Aug 8, 2017

@matthiasgeiger
Yes, I noticed this workaround.
BTW, thank you very much!

@lenhard
Copy link
Member

lenhard commented Aug 12, 2017

@Doc73 @matthiasgeiger I think I have fixed this. Can you please try out http://builds.jabref.org/fix-sourcetab-update/ and see if it works for you?

@Doc73
Copy link
Contributor Author

Doc73 commented Aug 12, 2017

@lenhard
Many thanks! It seems working!

@wujastyk
Copy link

Problem: in editor, bibtex source tab not updating.

Steps:

  1. add article
  2. go to optional fields, add DOI
  3. fetch DOI data and accept "replace"
  4. Fields all okay in Required tab
  5. All fields blank in Bibtex source tab.

JabRef 4.0-dev--snapshot--2017-08-11--master--18fffc6b9
Linux 4.8.0-58-generic amd64
Java 1.8.0_144

@matthiasgeiger
Copy link
Member

@wujastyk This should also be fixed by the change of @lenhard I just merged into the master branch.

Please try the newest version from https://builds.jabref.org/master. Thanks!

@wujastyk
Copy link

wujastyk commented Aug 14, 2017 via email

@lenhard
Copy link
Member

lenhard commented Aug 14, 2017

@wujastyk I've tried with the same JabRef version, but on Win7, but I cannot reproduce your problem. Can you give a DOI? I do the following:

  1. add article
  2. go to General fields tab, add DOI https://doi.org/10.1016/j.future.2017.01.006
  3. Click get BibTeX data from DOI
  4. Click replace
  5. All fields properly populated in the required tab and and in the BibTeX source tab

@wujastyk
Copy link

wujastyk commented Aug 14, 2017 via email

@koppor
Copy link
Member

koppor commented Aug 14, 2017

@wujastyk Did you customize your entry types somehow? (http://help.jabref.org/en/CustomEntryTypes)

@matthiasgeiger
Copy link
Member

I was able to reproduce the problem and I opened #3103 for this bug.

@wujastyk
Copy link

wujastyk commented Aug 14, 2017 via email

@matthiasgeiger
Copy link
Member

Have a good flight!
Should now be fixed in recent master builds.

@wujastyk
Copy link

wujastyk commented Aug 15, 2017 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Confirmed bugs or reports that are very likely to be bugs entry-editor
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants