Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalize to Bibtex name format #318

Closed
1 task done
stefan-kolb opened this issue Nov 11, 2015 · 7 comments
Closed
1 task done

Normalize to Bibtex name format #318

stefan-kolb opened this issue Nov 11, 2015 · 7 comments
Labels
bug Confirmed bugs or reports that are very likely to be bugs

Comments

@stefan-kolb
Copy link
Member

Rightclick formatter in authors field goes wrong.

Minimal example:

Stefan Kolb and J{\"o}rg Lenhard and Guido Wirtz

turns out to be

Kolb, Stefan and J{\"o}rg Lenhard and Wirtz, Guido

but should be

Kolb, Stefan and Lenhard, J{\"o}rg and Wirtz, Guido
  • NameListNormalizer should be transformed to a Formatter on that occasion.

On another note: is this really THE BibTex name format? This should help with multiple firstnames?!

@stefan-kolb stefan-kolb added the bug Confirmed bugs or reports that are very likely to be bugs label Nov 11, 2015
@oscargus
Copy link
Contributor

Yes, the Lastname, Firstname is THE BibTeX name format (if you should pick one). This is the only one that can handle Jr. and it also doesn't rely on "von" being spelled correctly (without capitals) for correct results.

A (possibly) related problem: The first name abbreviation for author column (and probably elsewhere) doesn't work as expected. Not sure if this happens to J{"o}rg, but for sure H{\aa}kan is abbreviated to H{\aa}. instead of H.

@stefan-kolb
Copy link
Member Author

What about Andreas Jr. {von Lastname}?

@oscargus
Copy link
Contributor

Assuming his name is Andreas von Lastname, Jr. the correct way would be "von Lastname, Jr., Andreas". Your entry results in: von Lastname, A. J. or A. J. von Lastname.

"In BibTeX's world view, a name has four components:

  1. First name (which includes any middle names provided)
  2. von ("de la" or "van der" like components)
  3. Last (Surname without the von part)
  4. Jr (Things like "Jr.", "III", etc)"

http://nwalsh.com/tex/texhelp/bibtx-23.html says

To summarize, you may type a name in one of three forms:
"First von Last" "von Last, First" "von Last, Jr, First"
You may almost always use the first form; you shouldn't if either there's a Jr part or the Last part has multiple tokens but there's no von part.

@oscargus
Copy link
Contributor

There are more issues here:

Heng-Yu Jian and Xu, Z. and Chang, M.-C.F.

becomes

Heng-Yu Jian and Xu, Z. and Chang, M. -. C. F.

but I would expect

Jian, Heng-Yu and Xu, Z. and Chang, M.-C. F.
Oscar Gustafsson and Linda S. DeBrunner and Victor DeBrunner and H{\aa}kan Johansson

becomes

Gustafsson, Oscar and Linda S. DeBrunner and Victor DeBrunner and H{\aa}kan Johansson

while I would expect

Gustafsson, Oscar and DeBrunner,  Linda S. and DeBrunner, Victor and Johansson, H{\aa}kan

So, some observations/guesses:

  • Adding spaces after dots is good, unless there's a dash
  • Last names with double capital letters doesn't work (Victor Debrunner resulted in Debrunner, Victor, but Linda S. Debrunner remained the same)
  • First names with dashes doesn't work

@oscargus
Copy link
Contributor

It is worth noting that the function producing the author string for the table column works better.

@koppor
Copy link
Member

koppor commented Nov 16, 2015

See #319 (comment) - maybe test cases for net.sf.jabref.model.entry.AuthorList should be added testing for your input strings and whether they are parsed correctly.

@oscargus
Copy link
Contributor

oscargus commented Dec 2, 2015

I think we should use BibtexNameFormatter, since that method is quite likely to get it correct. :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Confirmed bugs or reports that are very likely to be bugs
Projects
None yet
Development

No branches or pull requests

3 participants