Replace NormalizeNamesFormatter by AuthorList and so fix #318 #1149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and imporve the AuthorListParser to recognize colons as names separator
tobiasdiez
added
the
status: ready-for-review
| firstAbbr = removeStartAndEndBraces(firstabbr); | ||
| vonPart = removeStartAndEndBraces(von); | ||
| lastPart = removeStartAndEndBraces(last); | ||
| jrPart = removeStartAndEndBraces(jr); | ||
| } | ||
|
|
||
| public static String addDotIfAbbreviation(String name) { |
There was a problem hiding this comment.
How does this method compare to expandAll (?) in StringUtil? Could that be replaced by this (later) as this seems more competent?
There was a problem hiding this comment.
Ahh, I know the answer for that... Somehow I didn't see StringUtil in the diff the first time. :-)
|
Looks very nice! 👍 The MD thing is a bit challenging and either way we will do it wrong for one of the cases. If I were in medicine I would probably prefer not to expand MD (especially). |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem is that comma separated authors cannot be distingued from one author in BibTeX format.
For example
Name, della, firstcould be three names separated by commas or if interpreted as valid BibTeX string it is one author with lastname=name, jrpart=della, firstname=first.Thanks at all, but especially @oscargus, for creating many tests. Made implementing this PR way easier!