Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

key generator fails to parse colon #3359

Closed
jiajunwu opened this issue Oct 27, 2017 · 4 comments
Closed

key generator fails to parse colon #3359

jiajunwu opened this issue Oct 27, 2017 · 4 comments
Labels
bug Confirmed bugs or reports that are very likely to be bugs keygenerator

Comments

@jiajunwu
Copy link

jiajunwu commented Oct 27, 2017

It seems that in 4.0 (Mac version), when I customize the key generator to [author][year][veryshorttitle], the generated keys will include the trailing colon if there is one in the title. It also includes other special characters like (`).

I remember this wasn't the case in 3.6.

@lenhard
Copy link
Member

lenhard commented Oct 27, 2017

Could you please re-check the behavior with the most recent development version available here: http://builds.jabref.org/master/ and report what you find?

Since the release of 4.0 there have been changes in the key generation, which might also have affected this.

@lenhard lenhard added the status: waiting-for-feedback The submitter or other users need to provide more information about the issue label Oct 27, 2017
@jiajunwu
Copy link
Author

Sorry, on my mac it says things like file damaged and should be moved to trash. Your FAQ says I can avoid this by changing the security setting to allow apps from 'anywhere', but I don't have this option on my OS (Sierra, 10.12.6).

@i2000s
Copy link

i2000s commented Nov 15, 2017

I can verify that this happens in the latest 11-13 build on Windows:

JabRef 4.1-dev--snapshot--2017-11-13--master--c1d425a31
Windows 10 10.0 amd64 
Java 1.8.0_152

Not only the special characters like colon or '`' are kept in the key phrase, I also think it is not necessary to keep the curly brackets in the file name when the PDF file is downloaded from the fetcher automatically based on the bibtex information (the curly brackets are from the title entry in the bibtex code). But this could be a separate issue.

@tobiasdiez tobiasdiez added bug Confirmed bugs or reports that are very likely to be bugs keygenerator and removed status: waiting-for-feedback The submitter or other users need to provide more information about the issue labels Nov 16, 2017
tobiasdiez added a commit that referenced this issue Jan 2, 2018
…#3506)

* Refactor BibTeX key generator

* Fix #3359: Automatically remove colon and apostrophe from key pattern

* Minor code review and fix tests

* Fix localization

* Fix build after merge

* Merge
@tobiasdiez
Copy link
Member

This should be fixed in the latest development version. Could you please check the build from http://builds.jabref.org/master/. Thanks!

Siedlerchr added a commit that referenced this issue Jan 2, 2018
* upstream/master:
  Add oaDOI fulltext fetcher (#3581)
  Refactor export code to fix #3576 (#3578)
  Fix #3359: Automatically remove colon and apostrophe from key pattern (#3506)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Confirmed bugs or reports that are very likely to be bugs keygenerator
Projects
None yet
Development

No branches or pull requests

4 participants