Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BibTeX - customize entry types ordering issue #3411

Closed
sambo57u opened this issue Nov 7, 2017 · 3 comments
Closed

BibTeX - customize entry types ordering issue #3411

sambo57u opened this issue Nov 7, 2017 · 3 comments
Labels
bug Confirmed bugs or reports that are very likely to be bugs entry-editor
Milestone
v4.1

Comments

@sambo57u
Copy link

sambo57u commented Nov 7, 2017

Using jabref-4.1-dev 2017-11-07 with java 1.8.0_152 on Linux x86_64.

  1. Open a bib file
  2. Select Bibtex - customize enttry types from menu
  3. Choose Article type (default)
  4. Select author and move it to top clcking the up button, order some other things
  5. Click Apply

The ordering immediately goes back to its original order and saving the bib file adheres to that
ordering in bibtex entries. I presume this is not the "required" ordering for Article type, in which
case the possibility to reorder should not be there. I have tested other functions but removing
items does seem to work, namely after the apply button they stay removed.
@tobiasdiez tobiasdiez added bug Confirmed bugs or reports that are very likely to be bugs entry-editor labels Nov 8, 2017
@tobiasdiez tobiasdiez added this to the v4.1 milestone Nov 8, 2017
@tobiasdiez
Copy link
Member

Probably introduced by my recent PR, where we moved from List to Set and might have lost the ordering on the way.

@lenhard
Copy link
Member

lenhard commented Nov 8, 2017

@tobiasdiez Maybe a LinkedHashSet is the way to go: https://docs.oracle.com/javase/8/docs/api/java/util/LinkedHashSet.html

It should preserve uniqueness of items and ordering.

tobiasdiez added a commit that referenced this issue Nov 10, 2017
@tobiasdiez
Fix #3411: ordering of fields in customized entry types works again
f222b0b
@tobiasdiez
Copy link
Member

This should be fixed in the latest development version. Could you please check the build from http://builds.jabref.org/master/. Thanks!

@lenhard Yes, that was the solution!

Siedlerchr added a commit that referenced this issue Nov 10, 2017
@Siedlerchr
Merge remote-tracking branch 'upstream/master' into sharelatex
fac2c3d 
* upstream/master: (26 commits)
  Fix test for quoted lang messages (#3424)
  Update gradle from 4.3 to 4.3.1
  Fix #3411: ordering of fields in customized entry types works again (#3422)
  Backport of syncLang to python2 (#3420)
  Remove Versioneye badge
  Fix some error prone warnings
  Fix for issue #2721 append to a field (#3395)
  Fix travis - hopefully
  Remove 3.x changelog (#3250)
  Try to use hint of https://github.com/TheBoegl/shadow-log4j-transformer#usage-as-library
  Try to enable LGTM
  Update guava from 23.2 -> 23.3 (#3409)
  Update wiremock from 2.8.0 -> 2.10.1
  Move groups field from others to general (#3407)
  Fix checkstyle issues to repair build
  Fix #3046: No longer allow duplicate fields in customized entry types (#3405)
  Strip invalid prolog when loading CitationStyles (#3404)
  Integrity check "Abbreviation Detection" detects abbreviated names for journals and booktitles based on the internal list instead of only looking for "." signs. (#3362)
  Update gradle from 4.2.1 to 4.3
  Update gradle from 4.2.1 to 4.3
  ...
Siedlerchr added a commit that referenced this issue Nov 18, 2017
@Siedlerchr
Merge remote-tracking branch 'upstream/master' into linuxlink
b60fbfe 
* upstream/master: (23 commits)
  Feature java version check again (#3428)
  Fix test for quoted lang messages (#3424)
  Update gradle from 4.3 to 4.3.1
  Fix #3411: ordering of fields in customized entry types works again (#3422)
  Backport of syncLang to python2 (#3420)
  Remove Versioneye badge
  Fix some error prone warnings
  Fix for issue #2721 append to a field (#3395)
  Fix travis - hopefully
  Remove 3.x changelog (#3250)
  Try to use hint of https://github.com/TheBoegl/shadow-log4j-transformer#usage-as-library
  Try to enable LGTM
  Update guava from 23.2 -> 23.3 (#3409)
  Update wiremock from 2.8.0 -> 2.10.1
  Move groups field from others to general (#3407)
  Fix checkstyle issues to repair build
  Fix #3046: No longer allow duplicate fields in customized entry types (#3405)
  Strip invalid prolog when loading CitationStyles (#3404)
  Integrity check "Abbreviation Detection" detects abbreviated names for journals and booktitles based on the internal list instead of only looking for "." signs. (#3362)
  Update gradle from 4.2.1 to 4.3
  ...
Siedlerchr added a commit that referenced this issue Nov 19, 2017
@Siedlerchr
Merge remote-tracking branch 'upstream/master' into selectFilesDlg
dbca24f 
* upstream/master: (30 commits)
  Add Hint for checking master version (#3439)
  Replace LinkedFiles backslashes with forward slashes (#3403)
  fix isbn result from chimbori (#3442)
  Feature java version check again (#3428)
  Fix test for quoted lang messages (#3424)
  Update gradle from 4.3 to 4.3.1
  Fix #3411: ordering of fields in customized entry types works again (#3422)
  Backport of syncLang to python2 (#3420)
  Remove Versioneye badge
  Fix some error prone warnings
  Fix for issue #2721 append to a field (#3395)
  Fix travis - hopefully
  Remove 3.x changelog (#3250)
  Try to use hint of https://github.com/TheBoegl/shadow-log4j-transformer#usage-as-library
  Try to enable LGTM
  Update guava from 23.2 -> 23.3 (#3409)
  Update wiremock from 2.8.0 -> 2.10.1
  Move groups field from others to general (#3407)
  Fix checkstyle issues to repair build
  Fix #3046: No longer allow duplicate fields in customized entry types (#3405)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Confirmed bugs or reports that are very likely to be bugs entry-editor
Projects
None yet
Milestone
v4.1
Development

No branches or pull requests
3 participants
@lenhard @tobiasdiez @sambo57u