Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fetching error #3463

Closed
melTr opened this issue Nov 28, 2017 · 10 comments
Closed

Fetching error #3463

melTr opened this issue Nov 28, 2017 · 10 comments
Labels
bug Confirmed bugs or reports that are very likely to be bugs import status: waiting-for-feedback The submitter or other users need to provide more information about the issue

Comments

@melTr
Copy link
Contributor

melTr commented Nov 28, 2017

JabRef version 4 Windows7
First time I got this error. We have trouble with our university network, so it could explained. But in this case, I guess user should receive an error message (for now, it just turns endless).

107024 results found. Only 50 relevant results will be fetched by default.
Uncaught exception occurred in Thread[JabRef CachedThreadPool,6,main]
java.lang.NullPointerException
	at org.jabref.logic.importer.fileformat.MedlineImporter.parseArticle(MedlineImporter.java:344)
	at org.jabref.logic.importer.fileformat.MedlineImporter.importDatabase(MedlineImporter.java:162)
	at org.jabref.logic.importer.fetcher.MedlineFetcher.fetchMedline(MedlineFetcher.java:207)
	at org.jabref.logic.importer.fetcher.MedlineFetcher.performSearch(MedlineFetcher.java:179)
	at org.jabref.gui.importer.fetcher.SearchBasedEntryFetcher.processQuery(SearchBasedEntryFetcher.java:37)
	at org.jabref.gui.importer.fetcher.GeneralFetcher.lambda$actionPerformed$5(GeneralFetcher.java:216)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source)
	at java.lang.Thread.run(Unknown Source)

Thanks

@lenhard
Copy link
Member

lenhard commented Nov 28, 2017

From the stacktrace you've posted, it looks like a bug. It shouldn't be too hard to fix. An additional null check at the respective position in code.

@lenhard lenhard added bug Confirmed bugs or reports that are very likely to be bugs import labels Nov 28, 2017
@curtcorum
Copy link

curtcorum commented Nov 29, 2017

@melTr and @lenhard

It may be something on the medline side!

I am experiencing multiple versions of JabRef on multiple hosts that did work with Pubmed/Medline suddenly not working today. They were working as recently as yesterday. I went and tried a recent development snapshot to make sure.

20:00:38.641 [JabRef CachedThreadPool] ERROR net.sf.jabref.FallbackExceptionHandler - Uncaught exception Occurred in Thread[JabRef CachedThreadPool,6,main]
java.lang.NullPointerException: null
at net.sf.jabref.logic.importer.fileformat.MedlineImporter.parseArticle(MedlineImporter.java:344) ~[JabRef-3.8.2.jar:?]
at net.sf.jabref.logic.importer.fileformat.MedlineImporter.importDatabase(MedlineImporter.java:162) ~[JabRef-3.8.2.jar:?]
at net.sf.jabref.logic.importer.fetcher.MedlineFetcher.fetchMedline(MedlineFetcher.java:204) ~[JabRef-3.8.2.jar:?]
at net.sf.jabref.logic.importer.fetcher.MedlineFetcher.performSearch(MedlineFetcher.java:176) ~[JabRef-3.8.2.jar:?]
at net.sf.jabref.gui.importer.fetcher.SearchBasedEntryFetcher.processQuery(SearchBasedEntryFetcher.java:37) ~[JabRef-3.8.2.jar:?]
at net.sf.jabref.gui.importer.fetcher.GeneralFetcher.lambda$actionPerformed$5(GeneralFetcher.java:217) ~[JabRef-3.8.2.jar:?]
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) ~[?:1.8.0_144]
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) ~[?:1.8.0_144]
at java.lang.Thread.run(Thread.java:748) [?:1.8.0_144]

20:07:59.728 [JabRef CachedThreadPool] ERROR org.jabref.FallbackExceptionHandler - Uncaught exception occurred in Thread[JabRef CachedThreadPool,6,main]
java.lang.NullPointerException: null
at org.jabref.logic.importer.fileformat.MedlineImporter.parseArticle(MedlineImporter.java:344) ~[JabRef-4.1-dev--snapshot--2017-11-27--master--42a959d1d.jar:?]
at org.jabref.logic.importer.fileformat.MedlineImporter.importDatabase(MedlineImporter.java:162) ~[JabRef-4.1-dev--snapshot--2017-11-27--master--42a959d1d.jar:?]
at org.jabref.logic.importer.fetcher.MedlineFetcher.fetchMedline(MedlineFetcher.java:207) ~[JabRef-4.1-dev--snapshot--2017-11-27--master--42a959d1d.jar:?]
at org.jabref.logic.importer.fetcher.MedlineFetcher.performSearch(MedlineFetcher.java:179) ~[JabRef-4.1-dev--snapshot--2017-11-27--master--42a959d1d.jar:?]
at org.jabref.gui.importer.fetcher.SearchBasedEntryFetcher.processQuery(SearchBasedEntryFetcher.java:37) ~[JabRef-4.1-dev--snapshot--2017-11-27--master--42a959d1d.jar:?]
at org.jabref.gui.importer.fetcher.GeneralFetcher.lambda$actionPerformed$5(GeneralFetcher.java:216) ~[JabRef-4.1-dev--snapshot--2017-11-27--master--42a959d1d.jar:?]
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) ~[?:1.8.0_144]
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) ~[?:1.8.0_144]
at java.lang.Thread.run(Thread.java:748) [?:1.8.0_144]

curt@curt-laptop-ubuntu:~/bin$ java -version
java version "1.8.0_144"
Java(TM) SE Runtime Environment (build 1.8.0_144-b01)
Java HotSpot(TM) 64-Bit Server VM (build 25.144-b01, mixed mode)

Did something change in the medline output recently?

Is anybody else seeing this?

Curt

@curtcorum
Copy link

Possibly something has changed in the output format from medline...

"Late November 2017: PubMed's MEDLINE citations, translation tables, and the MeSH database will have been updated to reflect 2018 MeSH."

https://www.nlm.nih.gov/bsd/policy/yep_activities.html

@melTr
Copy link
Contributor Author

melTr commented Nov 29, 2017

Hmmm... @curtcorum You're probably right. I try on my home computer running Ubuntu 16.04 and I get the same error, so I guess it was not my network.

@Andyroo1966
Copy link

Having the same error running jabRef 4.0 on manjaro java 1.8.0_144

721953 results found. Only 50 relevant results will be fetched by default.
Uncaught exception occurred in Thread[JabRef CachedThreadPool,6,main]
java.lang.NullPointerException
at org.jabref.logic.importer.fileformat.MedlineImporter.parseArticle(MedlineImporter.java:344)
at org.jabref.logic.importer.fileformat.MedlineImporter.importDatabase(MedlineImporter.java:162)
at org.jabref.logic.importer.fetcher.MedlineFetcher.fetchMedline(MedlineFetcher.java:207)
at org.jabref.logic.importer.fetcher.MedlineFetcher.performSearch(MedlineFetcher.java:179)
at org.jabref.gui.importer.fetcher.SearchBasedEntryFetcher.processQuery(SearchBasedEntryFetcher.java:37)
at org.jabref.gui.importer.fetcher.GeneralFetcher.lambda$actionPerformed$5(GeneralFetcher.java:216)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
at java.lang.Thread.run(Thread.java:748)

@lenhard
Copy link
Member

lenhard commented Nov 29, 2017

It seems that they've made a part of the data (date created for articles) optional, but our code expected this to be there.

@melTr @Andyroo1966 @curtcorum I have pushed a fix and Medline fetch works for me again. Could you please try out the current dev version and let me know if it works for you: http://builds.jabref.org/master/

@lenhard lenhard added the status: waiting-for-feedback The submitter or other users need to provide more information about the issue label Nov 29, 2017
@melTr
Copy link
Contributor Author

melTr commented Nov 29, 2017

@lenhard Solved for me. Got other errors in journal but unrelated to this issue.

@lenhard
Copy link
Member

lenhard commented Nov 29, 2017

Ok, thanks! Then I am closing this one.

@lenhard lenhard closed this as completed Nov 29, 2017
@curtcorum
Copy link

curtcorum commented Nov 29, 2017

@lenhard Working, thanks!

JabRef 4.1-dev--snapshot--2017-11-29--master--42ba568ea
Linux 4.10.0-40-generic amd64
Java 1.8.0_151

@Andyroo1966
Copy link

Andyroo1966 commented Dec 4, 2017 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Confirmed bugs or reports that are very likely to be bugs import status: waiting-for-feedback The submitter or other users need to provide more information about the issue
Projects
None yet
Development

No branches or pull requests

4 participants