Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only log failed junit tests in travis #3510

Closed
Siedlerchr opened this issue Dec 10, 2017 · 5 comments
Closed

Only log failed junit tests in travis #3510

Siedlerchr opened this issue Dec 10, 2017 · 5 comments

Comments

@Siedlerchr
Copy link
Member

Siedlerchr commented Dec 10, 2017

Currently, all stuff from all tests is logged and printed out.
This makes it really hard to identify real failed tests, because some test throw exceptions, which are expected.
Nonetheless the internal JabRef logger log4j2 logs all this stuff, which makes it hard to find the real probelmatic issue

@tobiasdiez
Copy link
Member

I actually liked the output since it shows that we have a lot to improve 😄 In my opinion, a successful test should not log any errors (and actually also no warnings). But currently we have a lot of error-catcher that log and then rethrow the exception, witch lead to these verbose logs. I would attack it at the root, i.e. fix the code.

@koppor
Copy link
Member

koppor commented Dec 11, 2017

@Siedlerchr Could you provide screenshots of the logs or a pointer? So that quick-readers get an impression? - On Windows, I recommend snipaste.

@tobiasdiez
Copy link
Member

@koppor It's on every Travis build, e.g. https://travis-ci.org/JabRef/jabref/jobs/314497777 and look at the output of the "check" job.

@Siedlerchr
Copy link
Member Author

Maybe we can add it to the .gitignore files and so you can locally enable you debug mode and it won't affect the remote (travis) one

@stefan-kolb
Copy link
Member

Thank you for your report 👍
This should be fixed in current master. Please try the latest build from http://builds.jabref.org/master.

koppor added a commit that referenced this issue Nov 15, 2019
@koppor koppor mentioned this issue Nov 15, 2019
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants