Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fetcher 'Title' removes all spaces #4014

Closed
igreenman opened this issue May 6, 2018 · 3 comments
Closed

Fetcher 'Title' removes all spaces #4014

igreenman opened this issue May 6, 2018 · 3 comments
Labels
bug Confirmed bugs or reports that are very likely to be bugs fetcher

Comments

@igreenman
Copy link

igreenman commented May 6, 2018 •
edited
Loading

JabRef 4.2
Linux 4.16.6-1-arch amd64
Java 1.8.0_172

Steps to reproduce:

  1. New Entry
    Ctrl-N,
    ID Type Title
    ID Ultraluminous starbursts from supermassive black hole-induced outflows
  2. We get
    Fetcher 'Title' did not find an entry for id 'Ultraluminousstarburstsfromsupermassiveblackhole-inducedoutflows'.
  3. Works perfectly in the old version (JabRef 4.1).
@igreenman igreenman changed the title Fetcher 'Title' removes spaces Fetcher 'Title' removes all spaces May 6, 2018
Siedlerchr added a commit that referenced this issue May 6, 2018
@Siedlerchr
Do not trim text for TitleBasedFetcher
891546c 
Fixes #4014
@Siedlerchr Siedlerchr mentioned this issue May 6, 2018
Merged
6 tasks
@Siedlerchr Siedlerchr added bug Confirmed bugs or reports that are very likely to be bugs fetcher labels May 6, 2018
@Siedlerchr
Copy link
Member

There is a version that should fix this at https://builds.jabref.org/fixTitlefetcherwhitespace/ (Please try it out.

@Siedlerchr Siedlerchr added the status: waiting-for-feedback The submitter or other users need to provide more information about the issue label May 6, 2018
@igreenman
Copy link
Author

JabRef-4.3-dev--snapshot--2018-05-06--fixTitlefetcherwhitespace--bc32252cc.jar works without this problem.

@Siedlerchr
Copy link
Member

@igreenman Please let this issue open as long as the fix is not yet merged into master. On merge it will be automatically closed

@Siedlerchr Siedlerchr reopened this May 7, 2018
@Siedlerchr Siedlerchr added fixed-in-devBuilds and removed status: waiting-for-feedback The submitter or other users need to provide more information about the issue labels May 7, 2018
Siedlerchr added a commit that referenced this issue May 11, 2018
@Siedlerchr
Do not trim or remove whitespace from the title based id fetcher (#4016)
dae1c81 
* Do not trim text for TitleBasedFetcher
Fixes #4014

* add changelog

* add trimming epxlicit to fetchers
add some tests

* move doi trim to parse
add test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Confirmed bugs or reports that are very likely to be bugs fetcher
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Siedlerchr @igreenman