Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot add exclusions into XMP-metadata's XMP export privacy settings #4072

Closed
KOLANICH opened this issue Jun 1, 2018 · 7 comments
Closed
Labels
export / save good first issue An issue intended for project-newcomers. Varies in difficulty. type: enhancement

Comments

@KOLANICH
Copy link
Contributor

KOLANICH commented Jun 1, 2018

I guess we should
1 fix the exclusions mechanism
2 insert 'file' into default exclusions and enable it by default
3 stop storing files paths in bibtex

@Siedlerchr
Copy link
Member

@johannes-manner Maybe you can add some insight here

@KOLANICH KOLANICH changed the title XMP and PDF tags writer write even excluded fields, including file XMP and PDF tags writer writes even excluded fields, including file Jun 1, 2018
@johannes-manner
Copy link
Collaborator

Hey, can you please provide an example and your desired outcome and the problems you detected?

@johannes-manner johannes-manner added the status: waiting-for-feedback The submitter or other users need to provide more information about the issue label Jun 6, 2018
@KOLANICH
Copy link
Contributor Author

KOLANICH commented Jun 6, 2018 via email

@tobiasdiez
Copy link
Member

@KOLANICH I'm a bit lost with your description. What kind of "exclusions"? What is exactly the bug that you experience (please provide detailed steps, actual vs expected behavior)...

@KOLANICH
Copy link
Contributor Author

KOLANICH commented Jun 6, 2018

1 create a bib file
2 create a record, bind it to a pdf
3 Tools -> Write XMP metadata to PDFs
4 Open the PDF in a plain text editor and see your bibtex id and the path to the file there
5 Go to Options->Preferences-XMP-metadata
6 see that pdf and bibtexkey are not there, though they should
7 try to add them
8 You can't add more than 1 record by clicking + button. Even if you do that, your settings are not saved when you click OK.

@KOLANICH KOLANICH changed the title XMP and PDF tags writer writes even excluded fields, including file Cannot add exclusions into XMP-metadata's XMP export privacy settings Jun 6, 2018
@Siedlerchr Siedlerchr added export / save type: enhancement good first issue An issue intended for project-newcomers. Varies in difficulty. and removed status: waiting-for-feedback The submitter or other users need to provide more information about the issue labels Jun 12, 2018
@koppor
Copy link
Member

koppor commented Jul 9, 2018

Refs #3861

Siedlerchr added a commit that referenced this issue Aug 29, 2018
* fix loading and storing of XMP Field Exlusions

Fixes #4072

* rename variable

* fix l10n and replace textfield with combobox

* adjust xmp test and add case for xmp privacy

* add changelog

* make editable
remove explicit pref size adjustments

* add delete icon button to table
disable when checkbox is unchecked

* fix comment
@Siedlerchr
Copy link
Member

Thank you for reporting this issue. We think, that is already fixed in our development version and consequently the change will be included in the next release.

We would like to ask you to use a development build from https://builds.jabref.org/master and report back if it works for you. Please remember to make a backup of your library before trying-out this version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
export / save good first issue An issue intended for project-newcomers. Varies in difficulty. type: enhancement
Projects
None yet
Development

No branches or pull requests

5 participants