Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

can't generate bibtex for Chinese author #4169

Closed
1 task done
redleafnew opened this issue Jul 5, 2018 · 9 comments
Closed
1 task done

can't generate bibtex for Chinese author #4169

redleafnew opened this issue Jul 5, 2018 · 9 comments
Labels
component: citationkey-generator good first issue An issue intended for project-newcomers. Varies in difficulty. [outdated] type: bug Confirmed bugs or reports that are very likely to be bugs

Comments

@redleafnew
Copy link

redleafnew commented Jul 5, 2018 •
edited
Loading

JabRef version on

Steps to reproduce:

  1. The rule for generate key is [auth][year] and include Chinese authors in author field such as 王, 阳 and 张, 家发 and 胡, 喜军 and 李, 保明
  2. Ctrl+G to generate key
  3. only year appear in the key.
Log File 
Paste an excerpt of your log file here
@stefan-kolb stefan-kolb added [outdated] type: enhancement [outdated] type: bug Confirmed bugs or reports that are very likely to be bugs and removed [outdated] type: enhancement labels Jul 5, 2018
@redleafnew
Copy link
Author

However, when the comma was removed in the author, it worked.

@koppor koppor added the good first issue An issue intended for project-newcomers. Varies in difficulty. label Jul 9, 2018
@1160300208
Copy link
Contributor

Thank you. I'll fix this bug.

@redleafnew
Copy link
Author

thanks for your hard working, please let me know when the bug is fixed.

@ArrogantL
Copy link

I have a question,we should split names with "and" ,why use comma？
And If the comma is Chinese comma，all goes well.

@Linzhuo16
Copy link

the "and" is to distinguish between different people. the comma is used to distinguish between the first name and the last name. and it is different from the space. e.g. "lastname, firstname" or "firstname lastname"

@1160300420 1160300420 mentioned this issue Jul 22, 2018
Closed
1160300208 added a commit to 1160300208/jabref that referenced this issue Aug 7, 2018
@1160300208
Fix author list parser (JabRef#4169)
9fafd06
@1160300208 1160300208 mentioned this issue Aug 7, 2018
Merged
6 tasks
Siedlerchr pushed a commit that referenced this issue Aug 7, 2018
@1160300208 @Siedlerchr
Fix author list parser (#4169) (#4248)
7b93f26 
* Fix author list parser (#4169)

* remove the additional changelog entry
@Siedlerchr
Copy link
Member

Thanks to @1160300208 the issues is now fixed in the latest master.

@1160300208
Copy link
Contributor

@redleafnew Now you can use fixed version from http://builds.jabref.org/master/

Siedlerchr added a commit that referenced this issue Aug 8, 2018
@Siedlerchr
Merge remote-tracking branch 'upstream/master' into fixattachfilerela…
f4d151d 
…tive

* upstream/master:
  Update dependencies (#4251)
  Fix author list parser (#4169) (#4248)
  Solved #3823 File annotation (#4246)
  Fix importer vulnerability (#4240)
Siedlerchr added a commit that referenced this issue Aug 13, 2018
@Siedlerchr
Merge remote-tracking branch 'upstream/master' into fixdragandrop
737b1c3 
* upstream/master: (33 commits)
  Fix display of checkboxes
  Fix
  Remove Spin comments
  Fix#3861_build_addneeded/deleteobsoleteproperties2
  Fix#3861_build_addneeded/deleteobsoleteproperties
  Fix#3861_build
  Fix attach file does not relativize file path (#4252)
  Fix for issue koppor 254 (Auto cleanup url) (#4255)
  Fix#ReplaceString_ChangeConflict
  Fix#3861ReplaceString_solveConflict
  Fix#3861RS_conflicttest
  Fix#3861RS_conflicttest
  Remove changelog entries
  Fix#3861ReplaceString_checkStyle
  Fix#3861ReplaceString_Improvements
  Fix#3861ReplaceString_ContributeLog
  fix log4j slf4j dependency
  Update dependencies (#4251)
  Fix author list parser (#4169) (#4248)
  ReplaceStringMVVMPattern
  ...

# Conflicts:
#	src/main/java/org/jabref/gui/BasePanel.java
@xiaodongcentury
Copy link

thanks for your hard working, please let me know when the bug is fixed.

Hi, i am using JabRef (JabRef 5.2--2020-12-14--e9be339 Linux 5.9.0-4-amd64 amd64 Java 15.0.1) on Debian sid.
After importing the Chinese essay, manually insert a space or comma, such as 王, 阳 or 王 阳, the citationkey will generate successfully, but the Reference section of essay will display "王 阳"(there is a space between王 and 阳, not "王阳".
How could you resolve this problem, thanks!
image

@leeqifeng
Copy link

leeqifeng commented Jul 7, 2021 •
edited
Loading

Thank you. I'll fix this bug.

good job

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: citationkey-generator good first issue An issue intended for project-newcomers. Varies in difficulty. [outdated] type: bug Confirmed bugs or reports that are very likely to be bugs
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

FIx chinese author bibtex key generation
10 participants
@Siedlerchr @koppor @stefan-kolb @tobiasdiez @xiaodongcentury @redleafnew @Linzhuo16 @ArrogantL @1160300208 @leeqifeng