Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"copy preview" included unwanted HTML codes #4365

Closed
1 task done
wujastyk opened this issue Oct 9, 2018 · 8 comments
Closed
1 task done

"copy preview" included unwanted HTML codes #4365

wujastyk opened this issue Oct 9, 2018 · 8 comments

Comments

@wujastyk
Copy link

wujastyk commented Oct 9, 2018

JabRef version
JabRef 5.0-dev--snapshot--2018-10-09--master--29838ee59
Linux 4.15.0-36-generic amd64
Java 1.8.0_181

Steps to reproduce:

  1. select an entry
  2. display preview (alt+2)
  3. copy preview (ctrl+shft+C)
  4. paste preview

The result is tagged with HTML tags. In most situations, like pasting to a word-processor or editor, I don't want these.
Also, it's not possible to just select the previewed entry and copy it using the OS cut-n-paste system.

Please stop the "copy preview" command that putting HTML into the output. Just plain text into the paste buffer.
Another command which behaves as the present "copy preview" may be retained if there's user-demand.

Thanks!

@tb77phd
Copy link

tb77phd commented Oct 9, 2018

It doesn't do this in all cases:

Clicking Edit -> Copy preview from the menu and then pasting gives no HTML tags.

Typing Ctrl+Shift+C and then pasting gives no HTML tags.

Right-clicking in the preview window and then pasting does indeed give HTML tags.

I agree, HTML tags are not one usually wants when pasting information.

@wujastyk
Copy link
Author

wujastyk commented Oct 9, 2018 via email

@tb77phd
Copy link

tb77phd commented Oct 10, 2018

I see. Either a version issue or a system issue, probably. I am using JabRef 4.3.1 on a Windows 10-64bit.

@wujastyk
Copy link
Author

wujastyk commented Oct 10, 2018 via email

@tobiasdiez
Copy link
Member

Thanks to @Ali96kz this should be fixed in the latest development version. Could you please check the build from http://builds.jabref.org/master/. Thanks! Please remember to make a backup of your library before trying-out this version.

@wujastyk
Copy link
Author

wujastyk commented Dec 9, 2018

I've just tested today's snapshot

JabRef 5.0-dev--snapshot--2018-12-09--master--b52c97239
Linux 4.15.0-42-generic amd64
Java 1.8.0_191

and when I do ctrl-shift-C or use the cursor popup to copy the preview, then I get the string "null" with a newline copied to memory fourteen times:

null
null
null
null
null
null
null
null
null
null
null
null
null
null
null

If I select the preview text and the press Ctrl+C, I get a good copy of the entry, with no HTML.

@Ali96kz
Copy link
Contributor

Ali96kz commented Dec 25, 2018

Ok, Thanks for checking. Try to fix it.

@wujastyk
Copy link
Author

Yes, seems to be fixed now in the development release. Many thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants