Sorting of read-status isn't working as expected

[sgibb]

JabRef 5.0-dev--snapshot--2018-11-26--master--89d4d745c
Linux 4.18.0-2-amd64 amd64
Debian Linux buster
Java 1.8.0_191

• I have tested the latest development version from http://builds.jabref.org/master/ and the problem persists

After clicking on the read-status (the eye symbol) column header I would expect the following order: unread, skimmed, read (or in decreasing order: read, skimmed, unread). While unread seems to be always grouped and at the top/bottom the skimmed and read entries seem to be unsorted:

Steps to reproduce the behavior:

1. Mark some entries as read, skimmed, unread
2. Click on the column header read-status

[Siedlerchr]

Welcome!

First of all look in maintable and look at the View Model class to find out how the data in the maintable is added and setup.
For further questions you can ask in gitter chat. And take a look at the wiki, there is a high level architecture overview of JabRef

[bicodoc]

Hi. I'm unable to sign in to gitter because of Firefox "Content Security Policy", which has no search entry on the Firefox preferences page. I've looked at the wiki, and looked at BibEntryTableViewModel.java in org.jabref.gui.maintable, but have found no enlightenment there. If simply finding the code that needs to be fixed is going to be so difficult, I may not have the time to contribute. Can you offer specific help?

[tobiasdiez]

@bicodoc Thanks for your interest to fix this issue. The sorting of the ranking column is handled as follows:

jabref/src/main/java/org/jabref/gui/maintable/MainTableColumnFactory.java

Lines 200 to 202 in ed7ea50

	if (specialField == SpecialField.RANKING) {
	column.setComparator(new RankingFieldComparator());
	}

I guess you just need to add a similar comparator for the read-status.

[bicodoc]

Thanks for the reply and the info. It’ll take me a little while to get a handle on how this all fits together, but I’ll start on it this evening.

…

On Dec 5, 2018, at 2:50 PM, Tobias Diez ***@***.***> wrote: @bicodoc Thanks for your interest to fix this issue. The sorting of the ranking column is handled as follows: https://github.com/JabRef/jabref/blob/ed7ea5060ae9c854f840ae335117cab176c615fb/src/main/java/org/jabref/gui/maintable/MainTableColumnFactory.java#L200-L202 I guess you just need to add a similar comparator for the read-status. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

[Siedlerchr]

Thanks to @aman-coolinc1 this issuse is now resolve.d

We would like to ask you to use a development build from https://builds.jabref.org/master and report back if it works for you. Please remember to make a backup of your library before trying-out this version.

[sgibb]

Thanks @aman-coolinc1. Sorting by "read-status" is working as expected now!