Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

entry editor: select which fields to show wrapped #5021

Closed
ilippert opened this issue Jun 2, 2019 · 7 comments · Fixed by #5230
Closed

entry editor: select which fields to show wrapped #5021

ilippert opened this issue Jun 2, 2019 · 7 comments · Fixed by #5230

Comments

@ilippert
Copy link
Contributor

ilippert commented Jun 2, 2019

Current snap version on fedora 30

Whilst the Abstract field is shown in the entry editor as a wrapped field, a custom field is not shown as wrapped.

@ilippert
Copy link
Contributor Author

just to note that this "enhancement" worked as expected in JabRef 4.3.1.

@johann-petrak
Copy link

I think this is a bug, not a feature request as this has worked as expected before, has been used to enter text and now breaks all these use cases.

@tobiasdiez tobiasdiez added bug Confirmed bugs or reports that are very likely to be bugs and removed type: enhancement labels Jun 28, 2019
@stefan-kolb stefan-kolb reopened this Aug 24, 2019
@stefan-kolb stefan-kolb added status: waiting-for-feedback The submitter or other users need to provide more information about the issue and removed bug Confirmed bugs or reports that are very likely to be bugs labels Aug 24, 2019
@LinusDietz
Copy link
Member

can you post a screenshot with the "bug"?

#jabcon

@ilippert
Copy link
Contributor Author

ilippert commented Aug 25, 2019

updated now to latest snap version

I have this entry

@InCollection{Clark:2010Mem,
  author       = {Andy Clark},
  title        = {Memento's Revenge: Objections and Replies to the Extended Mind},
  chapter      = {3},
  editor       = {R. Menary},
  pages        = {43--66},
  abstract     = {In the movie, Memento, the hero, Leonard, suffers from a form of anterograde amnesia that results in an inability to lay down new memories. Nonetheless, he sets out on a quest to find his wife's killer, aided by the use of notes, annotated polaroids, and (for the most important pieces of information obtained) body tattoos. Using these resources he attempts to build up a stock of new beliefs and to thus piece together the puzzle of his wife's death. At one point in the movie, a character exasperated by Leonard's lack of biological recall, shouts: ``YOU know? What do YOU know. YOU don't know anything. In 10 minutes time YOU won't even know you had this conversation'' Leonard, however, believes that he does, day by day, come to know new things. But only courtesy of those photos, tattoos, tricks and ploys. Who is right?These are the kinds of question addressed at length in the paper (co-authored with David Chalmers) ``The Extended Mind'. Is the mind contained (always? sometimes? never?) in the head? Or does the notion of thought allow mental processes (including believings) to inhere in extended systems of body, brain and aspects of the local environment? The answer, we claimed, was that mental states, including states of believing, could be grounded in physical traces that remained firmly outside the head. As long as a few simple conditions were met (more on which below), Leonard's notes and tattoos could indeed count as new additions to his store of long-term knowledge and dispositional belief. In the present treatment I revisit this argument, defending our strong conclusion against a variety of subsequent observations and objections. In particular, I look at objections that rely on a contrast between the (putatively) intrinsic content of neural symbols and the merely derived content of external inscriptions, at objections concerning the demarcation of scientific domains via natural kinds, and at objections concerning the ultimate locus of agentive control and the nature of perception versus introspection. I also mention a possible alternative interpretation of the argument as (in effect) a reductio of the very idea of the mind as an object of scientific study. This is an interesting proposal,},
  annote       = {read 5/10/2010, London. I liked the paper. Clark defends his argument for an extended mind (incorporating things outside the brain) against various criticisms. It is a philosophical paper, involving mostly thought experiments. The point, really, is that cognition is situated in a socio-techno-natural environment.},
  crossref     = {Menary:2010},
  file         = {:Clark.A2010 Memento's Revenge Objections and Replies to the Extended.pdf:PDF},
  project      = {Thinking},
  ranking      = {rank4},
  readstatus   = {read},
  recommend-by = {A Billion Gadget Minds-Workshop},
  timestamp    = {2019-08-25 02:34},
}

and it shows in the entry editor these two fields - one with wrapped text, the other without.

please let me know, if you need further information.

1
Screenshot-20190825023339-1003x382

@LinusDietz LinusDietz removed the status: waiting-for-feedback The submitter or other users need to provide more information about the issue label Aug 25, 2019
tobiasdiez added a commit that referenced this issue Aug 25, 2019
Fixes #5021. Unknown fields are now treated as multi-line fields. In the future, we should provide an UI interface to specify or change properties of fields.
stefan-kolb pushed a commit that referenced this issue Aug 25, 2019
Fixes #5021. Unknown fields are now treated as multi-line fields. In the future, we should provide an UI interface to specify or change properties of fields.
@tobiasdiez
Copy link
Member

This should be fixed in the latest development version. Note that it only works for unknown fields. So for example, the field annotation is still displayed as a single-line field because it is a standard bibtex field.

Could you please check the build from http://builds.jabref.org/master/. Thanks! Please remember to make a backup of your library before trying-out this version.

@ilippert
Copy link
Contributor Author

Hi @tobiasdiez,
thanks - will only be able to check once it is rolled out to snap package.
Just to check my UI confusion: in the preferences|File I can specify which fields to save not wrapped. As a user I would expect that this would relate to how the field is displayed. I note the technical difference. However, it does not seem straight forward, if storage and display are handled differently, especially if a user makes an effort to specify fields in the preferences.
cheers,
ingmar

@johann-petrak
Copy link

Thanks I just tested this and can confirm that this now works for all unknown fields.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

5 participants