Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Import of abbreviation list with umlauts not correctly read in #5133

Closed
1 task done
equinitry opened this issue Jul 17, 2019 · 1 comment
Closed
1 task done

Import of abbreviation list with umlauts not correctly read in #5133

equinitry opened this issue Jul 17, 2019 · 1 comment
Labels
bug Confirmed bugs or reports that are very likely to be bugs

Comments

@equinitry
Copy link

equinitry commented Jul 17, 2019 •
edited
Loading

JabRef version JabRef 5.0-dev--snapshot--2019-07-17--master--b094bc6ab
Windows 10 10.0 amd64
Java 1.8.0_211

Importing or adding a Journal name with umlauts is scrambled and not correctly saved

Steps to reproduce the behavior:

  1. Open "Manage abbreviations" menu
  2. create a new list or import an existing one with journal names having umlauts
  3. "Save changes"
  4. reopen menu and have a look at the entry (also doesnt abbreviate it because not found)

looks like ISO <--> UTF8 encoding problem
@equinitry equinitry changed the title Import of abbreviation list with umlauts no correctly read in Import of abbreviation list with umlauts not correctly read in Jul 17, 2019
@stefan-kolb stefan-kolb added the bug Confirmed bugs or reports that are very likely to be bugs label Aug 24, 2019
stefan-kolb added a commit that referenced this issue Aug 24, 2019
@stefan-kolb
fix: use UTF-8 as default encoding for files
5ad88c9 
If we create journal abbrev files via the JabRef, they are saved in UTF-8.
So it makes sense to use this as default encoding. Also see #5133.
stefan-kolb added a commit that referenced this issue Aug 24, 2019
@stefan-kolb
fix: use UTF-8 as default encoding for files ~ resolves #5133
6b6f68a 
If we create journal abbrev files via the JabRef, they are saved in UTF-8.
So it makes sense to use this as default encoding. Also see #5133.
@stefan-kolb
Copy link
Member

Thank you for your report 👍
This should be fixed in current journal-abbrev-encoding. Please try the latest build from http://builds.jabref.org/journal-abbrev-encoding.

@stefan-kolb stefan-kolb mentioned this issue Aug 24, 2019
Merged
Siedlerchr added a commit that referenced this issue Aug 24, 2019
@Siedlerchr
Merge remote-tracking branch 'upstream/master' into fixlookupfulltext
4ef1460 
* upstream/master:
  fix bug where main file directory is not set correctly (#5215)
  Use UTF-8 as default encoding for files (#5213)
  fix: missing separator for unchanged diff words
  fix: use UTF-8 as default encoding for files ~ resolves #5133
  Minor improvements to TexParser
  Fix lookup entry types in enums (#5209)
github-actions bot pushed a commit that referenced this issue Dec 1, 2020
Squashed 'src/main/resources/csl-styles/' changes from 55200d0..a20406d
ac1ccad 
a20406d Added name of the editors of a given edition (#5140)
9881fc5 Ping on push, not PR, document role of dist-updater (#5137)
04668cc Create nouvelles-perspectives-en-sciences-sociales.csl (#5063)
1d94e21 Update bursa-uludag-universitesi-saglik-bilimleri-enstitusu.csl (#5047)
84f3893 Add Harvard style for Metropolia University of Applied Sciences (#5086)
8e43e79 Create opto-electronic-advances.csl (#5135)
36e4fba Update society-for-american-archaeology.csl (#5124)
69ca360 St. Paul Canon Law new style (#5138)
b490ab0 Update and rename st-paul-university-faculty-of-canon-law.csl to saint-paul-university-faculty-of-canon-law.csl
b498116 There is no en-CA locale
3c35f28 Metadata
7059cca Create tu-dortmund-agvm.csl (#5088)
c321c98 Create new Citation type (#5093)
a7edc8d Update international-organization.csl (#5103)
3d1a052 The AWS load balancer is messing things up (#5133)
ca3839b Fix sort by a single macro (#5136)
5d1a7e8 Update chungara-revista-de-antropologia-chilena.csl (#5123)
cd75d5d ping distribution-updater (#5132)
dcf473a Update wirtschaftsuniversitat-wien-health-care-management.csl (#5125)
a87085e Fix Harvard Praxisforschung Editors (#5130)
d4176ca Switch automated tests to Github Actions (#5111)
726d0d8 Radiology, MPP, CORR -- small fixes: https://forums.zotero.org/discussion/85883/doi-radiology#latest https://forums.zotero.org/discussion/51058/style-request-molecular-plant-pathology#latest https://forums.zotero.org/discussion/85678/citing-style-clinical-orthopaedics-and-related-research#latest
e23db68 Update to la-trobe-university-harvard style (#5119)
c54b278 Create wirtschaftsuniversitat-wien-health-care-management.csl (#5110)
62fb019 Create austral-entomology.csl (#5118)
afa328c Update iso690-author-date-en.csl (#5113)
5468dce Update iso690-author-date-fr-no-abstract.csl (#5112)
98af86c Update iso690-numeric-fr.csl (#5115)
09f84c4 Update iso690-author-date-fr.csl (#5114)
178a9e4 Fix current biology to superscript
1fa5ce7 Create droit-belge-centre-de-droit-prive-ulb.csl (#5107)
3a6a4bc Fix file modes (#5106)
48f50e5 Create chungara-revista-de-antropologia-chilena.csl (#5096)
1e848f8 Create the-journal-of-the-indian-law-institute.csl (#5100)
856524c Create molecular-biology.csl (#5101)
eeebbf4 Create harvard-harper-adams-university.csl (#5104)
d90993d Fix tests
d4037bf WIP: St Paul Canon Law style

git-subtree-dir: src/main/resources/csl-styles
git-subtree-split: a20406d
@koppor koppor moved this to Done in Prioritization Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Confirmed bugs or reports that are very likely to be bugs
Projects
Prioritization
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@stefan-kolb @equinitry