The context menu for entries is gone

[j0hannes]

JabRef version 5.0-dev

• I have tested the latest development version from http://builds.jabref.org/master/ and the problem persists

There is no context menu for Bibtex entries anymore (e.g. to change a field to Unicode)

Steps to reproduce the behavior:

1. Right click on any field (the only remaining option is "select all")

[tobiasdiez]

Reason is that the following code was commented-out:

jabref/src/main/java/org/jabref/gui/fieldeditors/EditorTextField.java

Lines 51 to 61 in f85c081

	@Override
	public void addToContextMenu(final Supplier<List<MenuItem>> items) {
	// TextFieldSkin customContextSkin = new TextFieldSkin(this) {
	// @Override
	// public void populateContextMenu(ContextMenu contextMenu) {
	// super.populateContextMenu(contextMenu);
	// contextMenu.getItems().addAll(0, items.get());
	// }
	// };
	// setSkin(customContextSkin);
	}

[Siedlerchr]

Ah, yes I remember it was accessing jdk internals or other forbidden things

[tobiasdiez]

This will not be easy to make work again I guess.

The relevant code moved now to TextInputControlBehavior
https://github.com/javafxports/openjdk-jfx/blob/662281e733fe59c667e8ba5e1d45eef1fcd93681/modules/javafx.controls/src/main/java/com/sun/javafx/scene/control/behavior/TextInputControlBehavior.java#L661.

Thus, it would be simple to derive from this behavior class and add additional items to the context menu. However, I don't see a way to replace the original behavior by our customized one, because the behavior is initialized here:
https://github.com/javafxports/openjdk-jfx/blob/4f0addff16de7182752bc60541f44baeb0e99d2a/modules/javafx.controls/src/main/java/javafx/scene/control/skin/TextFieldSkin.java#L151-L154
and behavior in TextFieldSkin is private. Thus, there seems to be no easy way to register a custom behavior class. Moreover, there are no real plans from the JavaFX team to make the behavior part open to customization: javafxports/openjdk-jfx#241.

Only option I see is the following:
Add listener for ContextMenuEvent and then get the behavior.contextMenu via reflection to add items. That's really ugly.

Question asked: javafxports/openjdk-jfx#583

[Siedlerchr]

The only other ways is to only add a new context menu. This disables the default one.

[j0hannes]

What about a button for each text field? That button could also indicate possible issues (like the ugly yellow triangle to the left bottom of each field, which was always a pain to hit).

[tobiasdiez]

This is now re-implemented in the latest development version. Could you please check the build from http://builds.jabref.org/master/. Thanks! Please remember to make a backup of your library before trying-out this version.