-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow to load customized css #5790
Comments
Thanks for your suggestion. What do you mean in detail: reduce the size of the icons, or remove them completely? |
small detail but I agree with @thanever |
Decision:
We will tag as good first issue for newcomers and hope for contributions. |
In a bit more detail, the following needs to be done:
As a workaround, it is already possible to specify the css as a command line argument as described here: jabref/src/main/java/org/jabref/gui/util/ThemeLoader.java Lines 24 to 35 in b6c2663
This method should be properly documented by adding it with a bit more details to http://devdocs.jabref.org. |
Hey, I would like to try to solve this issue 😃 |
* Add CSS file type, add button in preferences to import a custom CSS file, started on import functionality * Change so that the log uses format specifiers instead of string concatenation * Add RadioButton for toggling custom theme * Add preference for setting the path to custom CSS theme * Load custom CSS if toggled * Add missing language keys * Remove check if the current theme is applied again, the check is removed since we don't need it * Save path to the custom CSS file in program preferences
* Add method for saving theme to file * Add modal for selection witch theme to export as CSS
I have implemented the requested feature and created a pull request #6036 |
Thank you for submitting a PR. While seeing the solution, we improved our specification. Maybe, you can work on finalizing the PR? |
* feat/#1 Add CSS file type, add button in preferences to import custom CSS file, started on import functionality * feat/#1 Change so that the log messages uses format specifiers instead of string concatenation * feat/#1 Add RadioButton for toggling custom theme * feat/#1 Add preference for setting path to custom CSS theme * feat/#1 Load custom CSS if toggled * feat/#1 Add missing language keys * feat/#1 Remove check if current theme is applied again, check is remove since we don't need it * feat/#1 Save path to custom CSS file in program preferences * Add functionality to let the user import custom CSS file #5790 * Add CSS file type, add button in preferences to import a custom CSS file, started on import functionality * Change so that the log uses format specifiers instead of string concatenation * Add RadioButton for toggling custom theme * Add preference for setting the path to custom CSS theme * Load custom CSS if toggled * Add missing language keys * Remove check if the current theme is applied again, the check is removed since we don't need it * Save path to the custom CSS file in program preferences * fix/#5 Add checks so that the theme change notification is only shown once, disable custom theme radio button i no custom theme has been imported * Remove added stuff from merge conflict * Add export current theme #5790 * Add method for saving theme to file * Add modal for selection witch theme to export as CSS * Add missing language lines * Add information about import/export of themes, #5790 * Fix CodaCy and checkstyle issues, #5790 * Add fixes from code review, #5790 * Remove unused import #5790 * Move the import/export buttons to the Appearance tab #5790 * Fixed merge errors * Fixed easy remarks * Introduced AppereancePreferences and changed some visual elements * Refactored ExportThemeDialog * Fixed merge error * Removed export theme logic and added validation * CHANGELOG.md * Removed obsolete viewmodel class * Refactored io.File to nio.Path, use of JabRefPreferences and removed vmOption * Refactored ThemeLoader object class to enum with static util methods * Fixed overlooked merge error * Refactored static methods to object methods * Checkstyle Co-authored-by: Nils Streijffert <nils.streijffert@gmail.com> Co-authored-by: Christoph <siedlerkiller@gmail.com>
Would reducing the height of the part shown in the figure below make appearance more coordinated?
The text was updated successfully, but these errors were encountered: