Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add icon picker in group edit dialog #6142

Closed
tobiasdiez opened this issue Mar 17, 2020 · 10 comments · Fixed by #7776
Closed

Add icon picker in group edit dialog #6142

tobiasdiez opened this issue Mar 17, 2020 · 10 comments · Fixed by #7776
Labels
good first issue An issue intended for project-newcomers. Varies in difficulty. groups type: enhancement

Comments

@tobiasdiez
Copy link
Member

tobiasdiez commented Mar 17, 2020

As noted recently, the user has to manually lookup the icon-code and put it in the "Edit group" dialog. Instead, we should show a (searchable) list of all available icons.

Example for how the UI can look like: https://itsjavi.com/fontawesome-iconpicker/ (and maybe https://dmdc0de.github.io/material-ui-icon-picker/ )
image

Example code for a similar implementation in JavaFX: https://github.com/kordamp/ikonli/blob/18b3fb679d358801f5730352014cdbc780aff31a/apps/sampler-javafx/src/main/java/org/kordamp/ikonli/sampler/javafx/Sampler.java#L131-L153

@github-actions
Copy link
Contributor

github-actions bot commented Dec 8, 2020

This issue has been inactive for half a year. Since JabRef is constantly evolving this issue may not be relevant any longer and it will be closed in two weeks if no further activity occurs.

As part of an effort to ensure that the JabRef team is focusing on important and valid issues, we would like to ask if you could update the issue if it still persists. This could be in the following form:

  • If there has been a longer discussion, add a short summary of the most important points as a new comment (if not yet existing).
  • Provide further steps or information on how to reproduce this issue.
  • Upvote the initial post if you like to see it implemented soon. Votes are not the only metric that we use to determine the requests that are implemented, however, they do factor into our decision-making process.
  • If all information is provided and still up-to-date, then just add a short comment that the issue is still relevant.

Thank you for your contribution!

@Siedlerchr
Copy link
Member

Refs #7058

@Siedlerchr Siedlerchr added the good first issue An issue intended for project-newcomers. Varies in difficulty. label Feb 24, 2021
@Siedlerchr
Copy link
Member

As the switch from fontawesomefx to Ikonli is now finished it should be relatively easy to implement an icon picker dialog.
Example from the Ikonli project can probably be adapted
https://github.com/kordamp/ikonli/blob/master/apps/ikonli-browser/src/main/java/org/kordamp/ikonli/browser/IkonPickerDialog.java

@aakarshvats638
Copy link

I would like to work on this issue can you please elaborate what is to be done?

@tobiasdiez
Copy link
Member Author

Thanks for your interest. When you right-click a group and choose "Edit group" you get an dialog with an "icon" text field (among other input fields). Right now the user needs to put the name of the icon in this text field. It would be good if there would be a graphical input possibility, similar to
image

(taken from the link in the issue description)

@srdeotarse
Copy link

I want to participate in GSOC 2021, so I would like to work on this issue with dropdown icon combobox as suggested by @tobiasdiez @Siedlerchr

@tobiasdiez
Copy link
Member Author

@srdeotarse Thanks for your interest! @aakarshvats638 do you still plan to work on this, or even already started?

@NicholasBian
Copy link
Contributor

Hi! We are a group of 4 students from the University of Adelaide, and we are learning to contribute to open source projects. Is anyone currently working on this issue? If not, we'd like to help with this issue. Any guidance would be appreciated. Cheers!

@EricLee543
Copy link

EricLee543 commented May 19, 2021

image
I have implemented a simple demo like this. However, there is a problem. I can only load 1000 icons. If I load all of the icons, there will be UI lags.
Do you think 1000 icons are enough? Maybe we can keep the previous way, and add a limited(1000 icons) icon picker.
@tobiasdiez @Siedlerchr

@tobiasdiez
Copy link
Member Author

That looks very nice! Good job.

Concerning the performance problem, how did you implement the grid? It might be necessary to use something like https://github.com/FXMisc/Flowless to not create 1000 buttons but only a couple (essentially what fits in the display) and reuse them when scrolling. I would suggest you open a draft PR where we can discuss these things.

koppor pushed a commit that referenced this issue Sep 1, 2022
8d69f16 Create university-of-hull-harvard.csl (#6146)
139dfdd Create current organic synthesis.csl (#6139)
bb006c8 Update acta-universitatis-agriculturae-sueciae.csl (#6143)
5815da0 Create food-science-and-biotechnology.csl (#6132)
2702a7c Update harvard-university-for-the-creative-arts.csl (#6104)
ef34543 Update economic-geology.csl (#6128)
0adcd30 Bump mathieudutour/github-tag-action from 5.6 to 6.0 (#6141)
3c36e97 Create universite-du-quebec-a-montreal-prenoms.csl (#6073)
415bc05 Bump softprops/action-gh-release from 0.1.14 to 1 (#6142)
ae8c5e4 Create politique-europeenne.csl (#6074)
09cbc09 Update cell-numeric-superscript.csl (#6188)
6ee1ace Update avian-conservation-and-ecology.csl (#6191)
cb5c43f Update harvard-anglia-ruskin-university.csl (#6189)
5c4f4c0 Create anais-da-academia-brasileira-de-ciencias.csl (#6066)
a60dfe9 Update cardiff-university-harvard.csl (#6190)
999a45c Create sociologia-urbana-e-rurale.csl (#6042)
1bc9d62 Bluebook (#6183)
a4f2a72 Oxford Brookes (#6182)
88df8d5 Delete harvard-cardiff-university-old.csl (#6180)
b9302fd Update APA styles for "event" macro (#6174)
d4daec6 remove DOI for printed articles organizational-studies.csl (#6176)
acfc620 Create liver-transplantation.csl (#6167)
129a775 Change "event" to "event-title" (#6164)

git-subtree-dir: buildres/csl/csl-styles
git-subtree-split: 8d69f16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue An issue intended for project-newcomers. Varies in difficulty. groups type: enhancement
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

6 participants