Paste button on maintable does not work properly

[ytzemih]

JabRef 5.1--2020-04-12--771af5d
Linux 5.4.19-050419-generic amd64
Java 14

• I have tested the latest development version from http://builds.jabref.org/master/ and the problem persists

Steps to reproduce the behavior:

1. Open two different bibfiles (A and B) with a couple of entries
2. Select and copy one or more entries from the entry table of file A (via Ctr-C or via the Copy button).
3. Switch to the entry table of file B.
4. Use the Paste button.
5. (For me) The entry is not inserted in file B.
6. Use Ctr-V instead and the entry is inserted in file B.

[AEgit]

JabRef 5.1--2020-04-14--e86d415
Windows 10 10.0 amd64
Java 14.0.1

Can confirm this issue.

[tobiasdiez]

This should be fixed in the latest development version. Could you please check the build from http://builds.jabref.org/master/. Thanks! Please remember to make a backup of your library before trying-out this version.

[AEgit]

JabRef 5.1--2020-04-20--bc57d22
Windows 10 10.0 amd64
Java 14.0.1

I can confirm, this has been fixed in the current dev version.

[ytzemih]

JabRef 5.1--2020-04-20--d9fe981
Linux 5.4.19-050419-generic amd64
Java 14.0.1

Can confirm, too. Thanks for the fix.

[calixtus]

Let's follow the mac related issue in #6419 .

[Siedlerchr]

We had to revert this fix as it is breaking copy pasting via keyboard shortcuts and results in duplicate entries on mac when you paste in a new library. Codewise this seems to be a general issue

[Siedlerchr]

The problem is that on MacOSX the command + v triggers the keyEvent which is handled in MainTable and consumed.
However, afterwards it still propagates to the owner of the keybinding, the EditAction which then is triggered like if someone had pressed the MenuItem manually.
Seems to be this bug: https://bugs.openjdk.java.net/browse/JDK-8205915

[koppor]

Decision: Disable in the code only for Mac (MainTable KeyHandler) - to get it working on Windows and Linux again.

[ytzemih]

I've just added an update to #6740

[calixtus]

😫

[calixtus]

I've just added an update to #6740

Thanks for your update. We'll look into it.

[Siedlerchr]

I guess the problem is that it doesn't work when the focus is not on the maintable,
probably sufficient to remove the second if
https://github.com/JabRef/jabref/blob/master/src/main/java/org/jabref/gui/edit/EditAction.java

[ytzemih]

I see, can anyone using Linux confirm this issue still being there?

[Siedlerchr]

Also I noticed that the paste bug in macos is now present in the TextField. I think wee need to disable it there.

[koppor]

Fixed in master, will be included in the v5.1 release. Should be released in a few hours.

[jhh931]

JabRef 5.1--2020-08-30--e023aa0
Windows 10 10.0 amd64
Java 14.0.2

Paste button does not function. Neither does ^v.

[koppor]

@jhh931 What did you copy? I tried copy from the maintable and paste into it.

[ytzemih]

JabRef 5.1--2020-08-30--e023aa0
Linux 5.4.19-050419-generic amd64
Java 14.0.2

Copy and paste per button and per keyboard shortcuts works for me under Linux.
However, what I can't seem to do: Copy by keyboard and paste by button, vice versa. So, as long as you stay with one method, it seems to work. (for me)

[jhh931]

Hey - I got some fresh new insights. Steps to reproduce:

1. Open two different bibfiles (A and B) with a couple of entries
2. Select and copy one or more entries from the entry table of file A (via Ctr-C or via the Copy button). (GUI says: "Copied x entries")
3. Switch to the entry table of file B (by clicking on the tab)
4. Right now, ^v does not work. Paste button does not work.
5. Click below the tab of file B (e.g. on the header row or in any row with an entry).
6. Now ^v does paste the copied entries into B. So does the Paste button.

[Siedlerchr]

We probably need to remove the if for the focus owner check for maintable and assume the maintable as default if not text input control
@calixtus

[Siedlerchr]

This issue should now be finally fixed in the new master.
https://builds.jabref.org/master/