Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable one column libreoffice panels #6639

Closed
liubenyuan opened this issue Jun 25, 2020 · 7 comments · Fixed by #6719
Closed

Enable one column libreoffice panels #6639

liubenyuan opened this issue Jun 25, 2020 · 7 comments · Fixed by #6719
Labels
component: libre-office component: ui good first issue An issue intended for project-newcomers. Varies in difficulty.

Comments

@liubenyuan
Copy link

Is your suggestion for improvement related to a problem? Please describe.
I am using jabref with LibreOffice, the connect panel is 3x3 grid with small icons on top. It is very inconvenient when citing references because the 3x3 grid makes the main panel of jabref narrower.

Describe the solution you'd like
would it be possible that this LibreOffice plugin is 1 column, i.e., a side panel.

Additional context
jabref

@tobiasdiez tobiasdiez added good first issue An issue intended for project-newcomers. Varies in difficulty. component: ui component: libre-office labels Jun 28, 2020
@tobiasdiez
Copy link
Member

Instead of using a fixed grid, a more flexible layout in forn of a Flowpane should be used. In this way the buttons can still be aligned in rows if there is enough space but move to the next row if the width is decreased. http://www.java2s.com/Code/Java/JavaFX/FlowPanepreferredwidthallowsfortwocolumns.htm

@ddunig2
Copy link
Contributor

ddunig2 commented Jul 27, 2020

I can make this change if that's alright.

@Siedlerchr
Copy link
Member

@ddunig2 Sure, go ahead

@ddunig2 ddunig2 mentioned this issue Jul 27, 2020
5 tasks
ddunig2 added a commit to ddunig2/jabref that referenced this issue Jul 27, 2020
tobiasdiez added a commit that referenced this issue Jul 28, 2020
* changed part of LibreOffice side panel to flow layout

* fixed the ordering of imports added for this issue

* updated change log for issue #6639

* Improved change log entry a bit

Co-authored-by: Tobias Diez <tobiasdiez@gmx.de>
@tobiasdiez
Copy link
Member

Thanks to the quick initiative of @ddunig2 this should be fixed in the latest development version. Could you please check the build from http://builds.jabref.org/master/. Thanks! Please remember to make a backup of your library before trying-out this version.

@ddunig2
Copy link
Contributor

ddunig2 commented Jul 28, 2020

Glad I can help! @tobiasdiez why check the build? Is there something else I need to do for this issue?

@tobiasdiez
Copy link
Member

This was directed to @liubenyuan, so that he/she can verify that the fix indeed works as expected. No further action required from your side, except for looking for your next issue that you want to fix ;-).

@liubenyuan
Copy link
Author

Sure, I will download the test version and try it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: libre-office component: ui good first issue An issue intended for project-newcomers. Varies in difficulty.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants