Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot delete standard entry types #6906

Closed
teertinker opened this issue Sep 12, 2020 · 1 comment · Fixed by #6933
Closed

Cannot delete standard entry types #6906

teertinker opened this issue Sep 12, 2020 · 1 comment · Fixed by #6933
Labels
good first issue An issue intended for project-newcomers. Varies in difficulty. type: enhancement ui

Comments

@teertinker
Copy link
Contributor

Ubuntu 20.04, JabRef 5.1
The following image shows the dialog to customize entry types. I want to delete the entry "Patent" because I never use it. I click on the trash icon. "Patent" disappears. I accept changes. I open the entry type dialog again.

Result:
"Patent" appears again

Expected behavior:
"Patent" is deleted

Alternative behavior:
"Patent" is a standard field in bixtex, the trash icon shouldn't only appear for user defined entry types.

grafik
@Siedlerchr Siedlerchr changed the title Customization of Entry types not saved Cannot delete standard entry types Sep 12, 2020
@Siedlerchr
Copy link
Member

Thanks for the report. Actually, you cannot delete the standard entry types. They are always recreated.
However, you can remove/modfiy the fields of the entry type.

=> We should show the trash icon only for custom entry types

@Siedlerchr Siedlerchr added the good first issue An issue intended for project-newcomers. Varies in difficulty. label Sep 12, 2020
dawidm added a commit to dawidm/jabref that referenced this issue Sep 22, 2020
@dawidm
Fix remove actions for entry types in the editor
971e246 
fixes JabRef#6906
* Created separate view models for standard and custom entry types, adding remove icon only for the custom ones
* Updated CHANGELOG.md
@dawidm dawidm mentioned this issue Sep 22, 2020
Merged
5 tasks
Siedlerchr added a commit that referenced this issue Sep 24, 2020
@dawidm @Siedlerchr
Fix remove actions for entry types in the editor (#6933)
0480a89 
* Fix remove actions for entry types in the editor
fixes #6906
* Created separate view models for standard and custom entry types, adding remove icon only for the custom ones
* Updated CHANGELOG.md

* Update CHANGELOG.md

Co-authored-by: Christoph <cschwentker@gmail.com>

* Fix code style

* Remove unnecessary class StandardEntryTypeViewModel

Co-authored-by: Christoph <cschwentker@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue An issue intended for project-newcomers. Varies in difficulty. type: enhancement ui
Projects
Features & Enhancements
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix remove actions for entry types in the editor dawidm/jabref
2 participants
@Siedlerchr @teertinker