Snap build no longer working

[Siedlerchr]

From the action:

Downloading 'JabRef-5.2-portable_linux.tar.gz' 0%
Downloading 'JabRef-5.2-portable_linux.tar.gz' 100%
Failed to generate snap metadata: 'adopt-info' refers to part 'jabref', but that part is lacking the 'parse-info' property.
Run the same command again with --debug to shell into the environment if you wish to introspect this failure.
Error: The process '/usr/bin/sg' failed with exit code 2

https://forum.snapcraft.io/t/failed-to-generate-snap-metadata-adopt-info-refers-to-part-synfig-studio-but-that-part-is-lacking-the-parse-info-property/18733/11
https://github.com/JabRef/jabref/runs/1262693776?check_suite_focus=true

[Siedlerchr]

@LyzardKing Does this error occur locally as well?
I saw the error in the latest build from snapcraft.io as well:
I only found some old bug reports for that error. Seems to be related to some metadata

https://snapcraft.io/jabref/builds/1151925

Priming jabref-launcher 
Failed to generate snap metadata: 'adopt-info' refers to part 'jabref', but that part is lacking the 'parse-info' property.
Build failed
Traceback (most recent call last):
  File "/usr/lib/python3/dist-packages/lpbuildd/target/build_snap.py", line 258, in run
    self.build()
  File "/usr/lib/python3/dist-packages/lpbuildd/target/build_snap.py", line 247, in build
    env=env)
  File "/usr/lib/python3/dist-packages/lpbuildd/target/build_snap.py", line 100, in run_build_command
    return self.backend.run(args, env=full_env, **kwargs)
  File "/usr/lib/python3/dist-packages/lpbuildd/target/lxd.py", line 537, in run
    subprocess.check_call(cmd, **kwargs)
  File "/usr/lib/python3.6/subprocess.py", line 311, in check_call
    raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['lxc', 'exec', 'lp-bionic-amd64', '--env', 'LANG=C.UTF-8', '--env', 'SHELL=/bin/sh', '--env', 'SNAPCRAFT_BUILD_INFO=1', '--env', 'SNAPCRAFT_IMAGE_INFO={"build-request-id": "lp-59808670", "build-request-timestamp": "2020-10-16T12:50:22Z", "build_url": "https://launchpad.net/~build.snapcraft.io/+snap/800385119bd8f8b023fe0dab7fbce0bc/+build/1151555"}', '--env', 'SNAPCRAFT_BUILD_ENVIRONMENT=host', '--env', 'http_proxy=http://10.10.10.1:8222/', '--env', 'https_proxy=http://10.10.10.1:8222/', '--env', 'GIT_PROXY_COMMAND=/usr/local/bin/snap-git-proxy', '--', '/bin/sh', '-c', 'cd /build/jabref && linux64 snapcraft']' returned non-zero exit status 2.
Revoking proxy token...
RUN: /usr/share/launchpad-buildd/bin/in-target scan-for-processes --backend=lxd --series=bionic --arch=amd64 SNAPBUILD-1151555
Scanning for processes to kill in build SNAPBUILD-1151555

[LyzardKing]

I'll look into it.
I think it's mostly an temporary issue in build.snapcraft.io, because nothing changed on our part..
I'll test locally and see if we can override the setting.

[LyzardKing]

The version is pulled form the JabRef.cfg file included in the tar file,
but the version string is missing from that file now..
@Siedlerchr It's not a snap error, I'll change it to use the git descrive tags, that should set it to 5.1. instead of 5.2 if that's ok

[Siedlerchr]

@LyzardKing Thanks for the investigation. No idea wh the file is missing. Maybe jpackage no longer includes it in jdk15.
you can use the "snapcraft" branch https://github.com/JabRef/jabref/tree/snapcraft for your changes. for testing because otherwise the snap build won't be triggered

[LyzardKing]

I'm running tests locally, when i have something proper I'll upload to that branch then

[LyzardKing]

Why does git describe return v_2.9.2-12400-gaf203b655?
If I add --tags I get the correct version (v5.1-191-gaf203b655)

[Siedlerchr]

They changed something. I see that there is a hidden .jpackage.xml file in the app/lib folder

<?xml version="1.0" ?>
<jpackage-state version="15" platform="linux">
  <app-version>5.2.189</app-version>
  <main-launcher>JabRef</main-launcher></jpackage-state>

[LyzardKing]

I set it to read from there.
The tag issue is something related to how the tags are built on github, not a jpackage thing.

[LyzardKing]

I uploaded to the snapcraft branch.. should I open a PR or can we merge directly from there?

[Siedlerchr]

You can open a PR, makes it easier to see the actions.
I also wanted to try if the cfg is correclty generated when I put the '--app-version', "${project.version}",
to the image options.

[LyzardKing]

(on a different note.. could you bump the 5.1 release to stable in the snap store?

[Siedlerchr]

I promoted it to candidate and stable now. It was beta previously