Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Snapcraft: set version from new xml file #7031

Merged
merged 4 commits into from
Oct 19, 2020
Merged

Snapcraft: set version from new xml file #7031

merged 4 commits into from
Oct 19, 2020

Conversation

LyzardKing
Copy link
Collaborator

Fix #7022
A change in jpackage has moved the version to an xml file.
We can parse that to read the version and set it in the snap package

  • Change in CHANGELOG.md described (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked documentation: Is the information available and up to date? If not created an issue at https://github.com/JabRef/user-documentation/issues or, even better, submitted a pull request to the documentation repository.

@LyzardKing
Copy link
Collaborator Author

@Siedlerchr The error in the CI is the upload part, the snap built succesfully (and set the version)

@Siedlerchr
Copy link
Member

Yep I saw it. It's probably just a github secret thing which is not avaiable when non org members run the workflows. Nontheless, I added the switch to the image options in build.gradle to see if the cfg file then contains again the versinn number.

@LyzardKing
Copy link
Collaborator Author

As long as there's one file that we can parse it's fine.

@Siedlerchr
Copy link
Member

My fix attempt didn't help, but yours work so I merge

@Siedlerchr Siedlerchr merged commit 79f0221 into master Oct 19, 2020
@Siedlerchr Siedlerchr deleted the snapcraft branch October 19, 2020 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Snap build no longer working
2 participants