Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Style of checkboxes while searching in preferences #7226

Closed
1 task done
k3KAW8Pnf7mkmdSMPHz27 opened this issue Dec 22, 2020 · 4 comments · Fixed by #7258
Closed
1 task done

Style of checkboxes while searching in preferences #7226

k3KAW8Pnf7mkmdSMPHz27 opened this issue Dec 22, 2020 · 4 comments · Fixed by #7258
Labels
component: preferences component: ui good first issue An issue intended for project-newcomers. Varies in difficulty.

Comments

@k3KAW8Pnf7mkmdSMPHz27
Copy link
Member

k3KAW8Pnf7mkmdSMPHz27 commented Dec 22, 2020 •
edited
Loading

JabRef 5.2--2020-12-22--d83ef74
Mac OS X 10.15.7 x86_64
Java 15.0.1

When searching for an option in JabRef preferences, the checkbox has incorrect styling. The "unchecked" behaviour, while distinct from the "checked", is confusing since it still has a checkmark in it. This is a visual bug, the behaviour is still correct.

Steps to reproduce the behavior:

  1. Open Preferences
  2. Search for an option that uses checkbox (e.g. autosave)
  3. Observe a checkbox highlighted in red, check/uncheck it

Highlighted unchecked box
Highlighted unchecked box
Highlighted checked box
Highlighted checked box
@Siedlerchr Siedlerchr added good first issue An issue intended for project-newcomers. Varies in difficulty. component: preferences labels Dec 26, 2020
@eludif
Copy link
Contributor

eludif commented Dec 27, 2020

Hi, I would like to help contribute to fixing this issue. Thanks.

@Siedlerchr
Copy link
Member

Siedlerchr commented Dec 28, 2020 •
edited
Loading

@faeludire Welcome to JabRef. I suggest you take a look at the PreferencesSearchHandler and the PreferencesDialog.css
You probably need to adjust the rule for the searchHighlight in the css or define a more specific one for checkboxes
The checkbox style schema is explained here:
https://stackoverflow.com/a/44889214

eludif added a commit to eludif/jabref that referenced this issue Dec 28, 2020
@eludif
Fix style of checkboxes while searching in preferences (JabRef#7226)
ac7a83a 
Previously, highlighted unchecked CheckBoxes seemed to checked (visual bug)
@eludif eludif mentioned this issue Dec 28, 2020
Merged
5 tasks
Siedlerchr pushed a commit that referenced this issue Dec 28, 2020
@eludif
Fix style of highlighted checkboxes while searching in preferences (#…
c8798ef 
…7258)

* Fix style of checkboxes while searching in preferences (#7226)

Previously, highlighted unchecked CheckBoxes seemed to checked (visual bug)

* Add change to CHANGELOG.md

* fix markdown-lint issue with CHANGELOG.md
@Siedlerchr
Copy link
Member

Thanks to @faeludire this is now fixed.

@k3KAW8Pnf7mkmdSMPHz27
Copy link
Member Author

It is appreciated @faeludire !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: preferences component: ui good first issue An issue intended for project-newcomers. Varies in difficulty.
Projects
Features & Enhancements
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix style of highlighted checkboxes while searching in preferences eludif/jabref
3 participants
@Siedlerchr @k3KAW8Pnf7mkmdSMPHz27 @eludif