Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Excluding custom fields from merge dialog/import #8354

Open
funnym0nk3y opened this issue Dec 21, 2021 · 10 comments
Open

Excluding custom fields from merge dialog/import #8354

funnym0nk3y opened this issue Dec 21, 2021 · 10 comments

Comments

@funnym0nk3y
Copy link

Is your suggestion for improvement related to a problem? Please describe.
Importing data from DOI or ISBN sources usually includes a citation key which differs from the format used in the library. There is also a similar case for files, where there isn't anything one can get online.
However those fields are displayed in the import merge dialog where one needs to check each field if it should be included or not.
Custom import filters via a java class are way out of my abilities and I don't know if they could be used in online imports.

Describe the solution you'd like
The process of getting information online could be eased if there was the ability to customize the import of certain fields.

@Siedlerchr
Copy link
Member

This is already possible:
grafik

@Siedlerchr Siedlerchr added the status: waiting-for-feedback The submitter or other users need to provide more information about the issue label Dec 22, 2021
@funnym0nk3y
Copy link
Author

Thanks for the reply but I don't see how to in this image. Could you elaborate?

@Siedlerchr
Copy link
Member

Siedlerchr commented Dec 23, 2021

Checking the first option : Generate a new key for imported entries will overwrite the keys coming from an import.
E.g. the DOI fetcher returns @article{abcdefg.... Now the citation key generator will overwrite it with your defined pattern.e. g generating a new key for that entry to @article{einstein1980...

@k3KAW8Pnf7mkmdSMPHz27
Copy link
Member

Maybe references #1283

@funnym0nk3y
Copy link
Author

Unfortunately this does not solve my problem:

grafik

When importing additional data the citation key is still imported.

@Siedlerchr Siedlerchr removed the status: waiting-for-feedback The submitter or other users need to provide more information about the issue label Jan 13, 2022
@Siedlerchr
Copy link
Member

@funnym0nk3y I come back to this issue as I recently investigated another issue. If you not want to import the citation key, you should set it to the left or the middle option.

@Siedlerchr Siedlerchr added the status: waiting-for-feedback The submitter or other users need to provide more information about the issue label Mar 31, 2022
@funnym0nk3y
Copy link
Author

funnym0nk3y commented Mar 31, 2022

But I need to set this for each entry, right? Would be more convenient if one could disable citation key import entirely.

@Siedlerchr
Copy link
Member

ah now I understand your suggestion. you want to exclude certain fields from the merge dialog.
Could be considered in #6190

@Siedlerchr Siedlerchr added type: enhancement and removed status: waiting-for-feedback The submitter or other users need to provide more information about the issue labels Mar 31, 2022
@ThiloteE
Copy link
Member

ThiloteE commented Mar 31, 2022

@funnym0nk3y Please try https://builds.jabref.org/pull/8361/merge/

Disabling overwriting keys upon import can be enabled/disabled here:
image

This method works with your pull-request Christoph.

(Edit: I cannot reproduce #8354 (comment))

Edit²: My bad. If you click on merge, obviously the citation key will be used you chose. Now, if you had enabled the preference to overwrite citation keys, then EVEN IF YOU CHOOSE THE ORIGINAL KEY FROM INTERNET, then it will be overwritten using the citation key pattern you use in your library. At least, if you use the version of Jabref in this pull request.

@ThiloteE
Copy link
Member

Excluding custom fields from merge dialog of course goes beyond that. Would suggest to rename this issue then.

@Siedlerchr Siedlerchr changed the title Excluding custom keys from DOI/ISBN import Excluding custom fields from merge dialog/import Mar 31, 2022
@koppor koppor moved this to Normal priority in Features & Enhancements Nov 7, 2022
@github-project-automation github-project-automation bot moved this to Normal priority in Prioritization Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Normal priority
Development

No branches or pull requests

4 participants