Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URL field replaces '+' character with ' ' (white space) breaking URL #8448

Closed
2 tasks done
serialc opened this issue Jan 19, 2022 · 4 comments · Fixed by #8508
Closed
2 tasks done

URL field replaces '+' character with ' ' (white space) breaking URL #8448

serialc opened this issue Jan 19, 2022 · 4 comments · Fixed by #8508
Labels
good first issue An issue intended for project-newcomers. Varies in difficulty. [outdated] type: bug Confirmed bugs or reports that are very likely to be bugs

Comments

@serialc
Copy link

serialc commented Jan 19, 2022

JabRef version

5.5 (latest release)

Operating system

GNU / Linux

Details on version and operating system

Ubunut 21.10

Checked with the latest development build

  • I made a backup of my libraries before testing the latest development version.
  • I have tested the latest development version and the problem persists

Steps to reproduce the behaviour

  1. For an entry go to the General tab.
  2. Test this URL to see where it should go
  3. Enter the above URL into the URL field (in the General tab).
  4. Click the (chain icon) link icon for the entry in the reference list.
  5. Goes to a 'not found' page.

You can see the reason - as soon as you enter/paste the URL into the URL field the '+' in the URL is replaced with a white space.

Full version info:
JabRef 5.5--2022-01-17--27a05c7
Linux 5.13.0-25-generic amd64
Java 16.0.2
JavaFX 17.0.1+1

Appendix

...

Log File
Paste an excerpt of your log file here
@Siedlerchr Siedlerchr added good first issue An issue intended for project-newcomers. Varies in difficulty. [outdated] type: bug Confirmed bugs or reports that are very likely to be bugs labels Jan 19, 2022
@ThiloteE
Copy link
Member

Does not resolve the bug, but workaround so far: add the url in the library file via a text editor or in the {} Bibtex Source Tab.

e.g.:

@Article{test,
  title = {test},
  url   = {https://www.chicago.gov/content/dam/city/depts/cdot/Red%20Light%20Cameras/2022/Sutton+Tilahun_Chicago-Camera-Ticket_Exec%20Summary-Final-Jan10.pdf},
}

Clicking the (chain icon) link icon for the entry in the reference list correctly leads to the website, so it seems to be in the part of the code that writes to the url field. The above suggests it is not in the code that reads from the url field.

linyanna added a commit to linyanna/jabref that referenced this issue Jan 30, 2022
fixes JabRef#8448
This change fixes JabRef#8448. However, it seems to reverse the URLDecoding from previous updates.
alexandre-cremieux added a commit to alexandre-cremieux/jabref that referenced this issue Feb 18, 2022
* clean code
* add java doc
* test

issue: JabRef#8448
@alexandre-cremieux
Copy link
Contributor

alexandre-cremieux commented Feb 18, 2022

Hi!

I have a proposal for this issue. @Siedlerchr could you please take a look?

@Siedlerchr
Copy link
Member

@alexandre-cremieux Cool! Pleas open a PR so we can see review your changes

@alexandre-cremieux
Copy link
Contributor

alexandre-cremieux commented Feb 19, 2022

As this is my first PR on JabRef, it has been opened as a draft. Please tell me is anything is wrong in the process ;)

alexandre-cremieux added a commit to alexandre-cremieux/jabref that referenced this issue Feb 19, 2022
* clean code
* add java doc
* test

issue: JabRef#8448
alexandre-cremieux added a commit to alexandre-cremieux/jabref that referenced this issue Feb 21, 2022
* clean code
* add java doc
* test

issue: JabRef#8448
Siedlerchr pushed a commit that referenced this issue Feb 26, 2022
* clean code
* add java doc
* test

issue: #8448
@koppor koppor moved this to Done in Prioritization Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue An issue intended for project-newcomers. Varies in difficulty. [outdated] type: bug Confirmed bugs or reports that are very likely to be bugs
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants