Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A new protected terms file in the preferences is gone after a restart #8608

Closed
2 tasks done
Siedlerchr opened this issue Mar 26, 2022 · 2 comments · Fixed by #8609
Closed
2 tasks done

A new protected terms file in the preferences is gone after a restart #8608

Siedlerchr opened this issue Mar 26, 2022 · 2 comments · Fixed by #8609
Labels
component: preferences [outdated] type: bug Confirmed bugs or reports that are very likely to be bugs

Comments

@Siedlerchr
Copy link
Member

JabRef version

Latest development branch build (please note build date below)

Operating system

macOS

Details on version and operating system

No response

Checked with the latest development build

  • I made a backup of my libraries before testing the latest development version.
  • I have tested the latest development version and the problem persists

Steps to reproduce the behaviour

  1. Create a new Custom Protected Terms file in the Preferences -> Protected terms file
  2. Notice that the terms file is added.
  3. Save the preferences
  4. Reopen the preferences : Protected Terms file is still there
  5. Restart JabRef
  6. The protected terms file is no longer in the list

Appendix

No response
@Siedlerchr Siedlerchr added the [outdated] type: bug Confirmed bugs or reports that are very likely to be bugs label Mar 26, 2022
@HoussemNasri
Copy link
Member

I can reproduce this on windows too

@Siedlerchr
Copy link
Member Author

I foud the problem: The FXCollections.umodiedfableIbservableList adds a WeakListener which gets garbage collected https://stackoverflow.com/a/44343014

Siedlerchr added a commit that referenced this issue Mar 26, 2022
@Siedlerchr
Fix protectedTerms not stored due to weaklistener
96b2b59 
Fixes #8608
@Siedlerchr Siedlerchr mentioned this issue Mar 26, 2022
Merged
5 tasks
calixtus pushed a commit that referenced this issue Mar 26, 2022
@Siedlerchr
Fix protectedTerms not stored due to weaklistener (#8609)
075a228 
* Fix protectedTerms not stored due to weaklistener

Fixes #8608

* add changelog
@koppor koppor moved this to Done in Prioritization Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: preferences [outdated] type: bug Confirmed bugs or reports that are very likely to be bugs
Projects
Prioritization
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix protectedTerms not stored due to weaklistener JabRef/jabref
2 participants
@Siedlerchr @HoussemNasri