Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only have active buttons for undo/redo if there is something to undo/redo #8807

Closed
claell opened this issue May 16, 2022 · 5 comments · Fixed by #11758
Closed

Only have active buttons for undo/redo if there is something to undo/redo #8807

claell opened this issue May 16, 2022 · 5 comments · Fixed by #11758
Assignees
Labels
component: ui status: freeze Issues posponed to a (much) later future

Comments

@claell
Copy link
Contributor

claell commented May 16, 2022

Is your suggestion for improvement related to a problem? Please describe.
The current buttons for this can always be clicked. There is no visual clue or prevention from clicking them needlessly.

Describe the solution you'd like
Other applications deactivate them in cases where nothing can be undone/redone.

Additional context
grafik

@ThiloteE
Copy link
Member

@calixtus

@calixtus
Copy link
Member

Undo redo is currently partially broken and does not work consistently.
We have a very large project running in the background to modernize the codebase (up to 20 years old) and to implement certain design patterns like the command pattern. As soon as this is done fixing the undo manager should be a fairly simple task. But there is still some way to go...

@claell
Copy link
Contributor Author

claell commented May 17, 2022

Alright! I guess, that also explains #8770.

@ThiloteE ThiloteE added the status: freeze Issues posponed to a (much) later future label May 17, 2022
@calixtus
Copy link
Member

Sadly yes... 😅

@claell
Copy link
Contributor Author

claell commented May 17, 2022

Corresponding relevant line for the future seems to be this:

this.executable.bind(ActionHelper.needsDatabase(stateManager));

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: ui status: freeze Issues posponed to a (much) later future
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants