Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File field in General Tab of entry editor not adhering to dark theme #9119

Closed
ThiloteE opened this issue Sep 2, 2022 · 7 comments · Fixed by #9343
Closed

File field in General Tab of entry editor not adhering to dark theme #9119

ThiloteE opened this issue Sep 2, 2022 · 7 comments · Fixed by #9343
Assignees
Labels
Dark Theme entry-editor good first issue An issue intended for project-newcomers. Varies in difficulty. ui

Comments

@ThiloteE
Copy link
Member

ThiloteE commented Sep 2, 2022

Newest Development version (5.8, Linux Mint (Cinnamon)) as of from just now:

grafik

Refs #9114

@Siedlerchr Siedlerchr added the good first issue An issue intended for project-newcomers. Varies in difficulty. label Sep 2, 2022
@sreenath-tm
Copy link
Contributor

I'm interested in contributing to this issue, so before I start working it, would you mind sparing your time explaining what the fix will be like and pointing me to some resources to get started.

@Siedlerchr
Copy link
Member

@sreenath-tm Welcome to JabRef. First step would be to look into https://devdocs.jabref.org/getting-into-the-code/guidelines-for-setting-up-a-local-workspace.html

For some information on Themes:
https://docs.jabref.org/advanced/custom-themes
Basically, the Dark.css inherits from the Light.css and overwrites the color. So you need to set a different color for this textfield /highlight

@John-Poulos
Copy link

John-Poulos commented Sep 4, 2022

I too am interested and started yesterday to get my environment setup, thank you for the guide! I am having an error that I haven't found a workaround to yet. My build is successful, but when I try to run in windows cmd prompt using .\gradlew run I get an error:

`> Configure project :
Project : => 'org.jabref' Java module

Task :run
2022-09-04 19:48:29 [JavaFX Application Thread] org.jabref.logic.net.ssl.TrustStoreManager.createTruststoreFileIfNotExist()
INFO: Trust store path: C:\Users\John\AppData\Local\org.jabref\JabRef\ssl\truststore.jks
2022-09-04 19:48:29 [JavaFX Application Thread] org.jabref.gui.JabRefMain.start()
ERROR: Unexpected exception: java.lang.NullPointerException: Cannot invoke "String.isEmpty()" because "originalDirectory" is null
at org.jabref@100.0.0/org.jabref.preferences.JabRefPreferences.determineMainFileDirectory(JabRefPreferences.java:2174)
at org.jabref@100.0.0/org.jabref.preferences.JabRefPreferences.getFilePreferences(JabRefPreferences.java:2189)
at org.jabref@100.0.0/org.jabref.preferences.JabRefPreferences.getFileLinkPreferences(JabRefPreferences.java:1110)
at org.jabref@100.0.0/org.jabref.preferences.JabRefPreferences.getLayoutFormatterPreferences(JabRefPreferences.java:1123)
at org.jabref@100.0.0/org.jabref.preferences.JabRefPreferences.getCustomExportFormats(JabRefPreferences.java:2293)
at org.jabref@100.0.0/org.jabref.gui.JabRefMain.applyPreferences(JabRefMain.java:175)
at org.jabref@100.0.0/org.jabref.gui.JabRefMain.start(JabRefMain.java:106)
at javafx.graphics@18.0.2/com.sun.javafx.application.LauncherImpl.lambda$launchApplication1$9(LauncherImpl.java:847)
at javafx.graphics@18.0.2/com.sun.javafx.application.PlatformImpl.lambda$runAndWait$12(PlatformImpl.java:484)
at javafx.graphics@18.0.2/com.sun.javafx.application.PlatformImpl.lambda$runLater$10(PlatformImpl.java:457)
at java.base/java.security.AccessController.doPrivileged(AccessController.java:399)
at javafx.graphics@18.0.2/com.sun.javafx.application.PlatformImpl.lambda$runLater$11(PlatformImpl.java:456)
at javafx.graphics@18.0.2/com.sun.glass.ui.InvokeLaterDispatcher$Future.run(InvokeLaterDispatcher.java:96)
at javafx.graphics@18.0.2/com.sun.glass.ui.win.WinApplication._runLoop(Native Method)
at javafx.graphics@18.0.2/com.sun.glass.ui.win.WinApplication.lambda$runLoop$3(WinApplication.java:184)
at java.base/java.lang.Thread.run(Thread.java:833)

Deprecated Gradle features were used in this build, making it incompatible with Gradle 8.0.`

Any assistance would be greatly appreciated!

@sreenath-tm - would you care to collaborate? I have to complete this for a school assignment.

@Siedlerchr
Copy link
Member

@John-Poulos that issue has been fixed now, you may need to update/sync your fork

@NamanHimmatramka
Copy link

I'm looking to contribute, can you assign this issue to me, please?

@ThiloteE
Copy link
Member Author

ThiloteE commented Oct 9, 2022

Usually I would say first come, first served, but since both @John-Poulos and @sreenath-tm seem to not have created a pull-request within the last month and also have not voiced opposing views towards the request of NamanHimmatramka, I assume they have given up and will assign this to @NamanHimmatramka

@ThiloteE ThiloteE moved this to Free to take in Good First Issues Oct 14, 2022
@ThiloteE ThiloteE moved this from Free to take to Reserved in Good First Issues Oct 14, 2022
@ThiloteE
Copy link
Member Author

ThiloteE commented Nov 3, 2022

closing this issue in favour of #9340, which is a duplicate issue, but well explained.

I assume @NamanHimmatramka has chosen a different project to work on as well.

@ThiloteE ThiloteE closed this as completed Nov 3, 2022
Repository owner moved this from Reserved to Done in Good First Issues Nov 3, 2022
@koppor koppor moved this to Done in Prioritization Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dark Theme entry-editor good first issue An issue intended for project-newcomers. Varies in difficulty. ui
Projects
Archived in project
Archived in project
Development

Successfully merging a pull request may close this issue.

5 participants