Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

File field needs to adjust to Dark theme #9340

Closed
2 tasks done
juejung opened this issue Nov 2, 2022 · 1 comment · Fixed by #9343
Closed
2 tasks done

File field needs to adjust to Dark theme #9340

juejung opened this issue Nov 2, 2022 · 1 comment · Fixed by #9343
Labels
component: theming component: ui good first issue An issue intended for project-newcomers. Varies in difficulty.

Comments

@juejung
Copy link

juejung commented Nov 2, 2022

JabRef version

Latest development branch build (please note build date below)

Operating system

GNU / Linux

Details on version and operating system

Ubuntu 22.04 with Gnome 42.4

Checked with the latest development build

  • I made a backup of my libraries before testing the latest development version.
  • I have tested the latest development version and the problem persists

Steps to reproduce the behaviour

  1. Open JabRef 5.8--2022-10-27--8df4a8e
  2. Switch to Dark Mode
  3. Add new entry
  4. Attach (link) a pdf to the entry via the File field
  5. The name of the pdf shows in black color and is hard to read in Dark Mode.
    Screenshot from 2022-11-02 10-04-28

Appendix

...

Log File 
Paste an excerpt of your log file here
@Siedlerchr Siedlerchr added component: ui good first issue An issue intended for project-newcomers. Varies in difficulty. component: theming labels Nov 2, 2022
@Siedlerchr Siedlerchr moved this to Free to take in Good First Issues Nov 2, 2022
@ThiloteE ThiloteE mentioned this issue Nov 3, 2022
Closed
@ThiloteE
Copy link
Member

ThiloteE commented Nov 3, 2022

Quoting @Siedlerchr :

For some information on Themes: https://docs.jabref.org/advanced/custom-themes Basically, the Dark.css inherits from the Light.css and overwrites the color. So you need to set a different color for this textfield /highlight

roryoday pushed a commit to roryoday/jabref that referenced this issue Nov 3, 2022
Fixed file field font color for dark mode JabRef#9340
94a52ab
roryoday pushed a commit to roryoday/jabref that referenced this issue Nov 3, 2022
Fixed file field font color for dark mode JabRef#9340
39b75b8
@roryoday roryoday mentioned this issue Nov 3, 2022
Merged
6 tasks
@ThiloteE ThiloteE moved this from Free to take to In Progress in Good First Issues Nov 3, 2022
calixtus pushed a commit that referenced this issue Nov 3, 2022
@roryoday
Fixed display of file field adjusting for the dark theme (#9343)
141c3e9 
* Fixed file field font color for dark mode #9340

* update CHANGELOG.md
Repository owner moved this from In Progress to Done in Good First Issues Nov 3, 2022
@ThiloteE ThiloteE mentioned this issue Dec 19, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: theming component: ui good first issue An issue intended for project-newcomers. Varies in difficulty.
Projects
Good First Issues
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixed display of file field adjusting for the dark theme roryoday/jabref
3 participants
@Siedlerchr @juejung @ThiloteE