-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add "A-Z" to translation key for group sorting #9304
Comments
Hi @koppor, I am a first timer. Can I work on this? |
As a general advice for newcomers: check out Contributing for a start. Also, guidelines for setting up a local workspace is worth having a look at. Feel free to ask here at GitHub, if you have any issue related questions. If you have questions about how to setup your workspace use JabRef's Gitter chat. Try to open a (draft) pull-request early on, so that people can see you are working on the issue and so that they can see the direction the pull request is heading towards. This way, you will likely receive valuable feedback. |
@ThiloteE, can you brief over the issue. Is the change required only in the line mentioned above? What changes are required in the JabRef_en.properties |
The change is required in two places: 1. in the line above and 2. in JabRef_en.properties I have never done anything related to translations before, so I am not too sure. As far as I understand it, JabRef is English native and all translations are based on JabRef's English localization, which would be JabRef_en.properties. If you change the English localization, it will trigger a change (or request to change?) the other languages as well. Correct me, if I am wrong. So, if you were to only change the above line, then only the code would be renamed, but users of JabRef would not notice, because this change would not be transmitted to JabRef's user interface. What changes are required? Simply rename |
Hi @ThiloteE, I have created a PR for this issue with the changes mentioned above. Can you verify if the changes are good? |
Here is the corresponding line
jabref/src/main/java/org/jabref/gui/groups/GroupTreeView.java
Lines 432 to 433 in fe2ceef
From
Localization.lang("Sort subgroups"));
toLocalization.lang("Sort subgroups A-Z"));
The
JabRef_en.properties
files needs to be adjusted then as well. The other files are handled by Crowdin.Originally posted by @Siedlerchr in #9248 (comment)
The text was updated successfully, but these errors were encountered: