-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Crowdin updates #9248
New Crowdin updates #9248
Conversation
@@ -867,7 +867,7 @@ Please\ check\ your\ library\ file\ for\ wrong\ syntax.=Veuillez vérifier la sy | |||
SourceTab\ error=Erreur de SourceTab | |||
User\ input\ via\ entry-editor\ in\ `{}bibtex\ source`\ tab\ led\ to\ failure.=La saisie de l'utilisateur via l'éditeur d'entrée dans l'onglet `{}bibtex source` a conduit à un échec. | |||
|
|||
Sort\ subgroups=Trier les sous-groupes | |||
Sort\ subgroups=Trier les sous-groupes A-Z |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems to got beyond the literal translation. Should we use this? @JabRef/vorstand
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed, it does go beyond literal translation to make clear which sort order is used.
Bad idea or to be propagated?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we then should better adjust the original string. E.g. sort subgroups alphabetically?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The difficulties for me are:
- I am not sure how good my suggestions are, and it seems overkill to open a PR for this small thing.
- I find it difficult to find the file where is the initial string (other services, like https://hosted.weblate.org/ gives the source file, which is convenient).
Not: I used A-Z instead of "alphabétiquement" to keep the menu shorter.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ThiloteE Should we replace that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure. Adjusting the original string also, intuitively seems better to me, but if the original string cannot be found ... i guess it's ok? Also, I don't know how it will look like in the UI
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
jabref/src/main/java/org/jabref/gui/groups/GroupTreeView.java
Lines 432 to 433 in fe2ceef
MenuItem sortSubgroups = new MenuItem(Localization.lang("Sort subgroups")); | |
sortSubgroups.setOnAction(event -> viewModel.sortAlphabeticallyRecursive(group.getGroupNode())); |
here is the corresponding line
The en.properties needs to be adjusted then as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in #9313
* upstream/main: New Crowdin updates (#9333) Refresh example styles Squashed 'buildres/csl/csl-styles/' changes from 4eee79a..13fd98e Bump unirest-java from 3.13.11 to 3.13.12 (#9330) Bump checkstyle from 10.3.4 to 10.4 (#9331) Bump gittools/actions from 0.9.14 to 0.9.15 (#9332) Group context menu presents relevant options depending on number of subgroups (#9286) Removed BibTeX file type and included HTML and Markdown types (#9318) Fix issue: Auto-linking files with safe character replacements #9267 (#9316) Fix for issue 8806: Button highlights doesn't respect rounded corners (#9320) New Crowdin updates (#9324) Update CHANGELOG.md Try to relocate listener binding (#9238) Changed the messages after importing unlinked local files to past passive tense. (#9308) Changed the color of found text from red to high contrast (#9315) New Crowdin updates (#9317) Add skips for MacOS X build (#9305) New Crowdin updates (#9248) Fix for issue 9304 (#9313) # Conflicts: # CHANGELOG.md
No description provided.