Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed the messages after importing unlinked local files to past passive tense. #9308

Merged
merged 5 commits into from
Oct 28, 2022
Merged

Changed the messages after importing unlinked local files to past passive tense. #9308

merged 5 commits into from
Oct 28, 2022

Conversation

Racheal7
Copy link
Contributor

Fixes koppor#548

This pull request changed the messages displayed after importing local files to past passive tense to indicate completion. Below are the screenshots of the original messages.

After importing the PDF file:
issue 548

After importing BibTex entry:
original import from bib

After creating empty entry:
No bibtex data found original

The updated messages are changed to past passive tense:

New message after importing the PDF file:
file was successfully imported as new entry

New message after importing the BibTex entry (the icon was changed to "check" as well):
bib entry was successfully imported

New messages after creating a new empty entry:
No bibtex data found updated

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@Racheal7 Racheal7 marked this pull request as ready for review October 25, 2022 12:09
Siedlerchr
Siedlerchr reviewed Oct 26, 2022
View reviewed changes
src/main/java/org/jabref/gui/externalfiles/ImportHandler.java
@@ -131,10 +131,10 @@ protected List<ImportFilesResultItemViewModel> call() {
}

entriesToAdd.addAll(bibtexParserResult.getDatabaseContext().getEntries());
addResultToList(file, false, Localization.lang("Importing bib entry"));
addResultToList(file, true, Localization.lang("Bib entry was successfully imported"));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any reason why this second value is now "true"? I am probably msissing some context here, but I was just wondering

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The icon for "successfully imported BibTex" was the red warning icon (the same as the icon for no data found). I assume it was a small bug and I changed the icon to the green check by changing the second parameter to true.

Original:
original import from bib 2

Updated:
bib entry was successfully imported

Copy link
Member

@Siedlerchr Siedlerchr Oct 27, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah thanks a lot! Can you mention this as well in the changelog? Thanks!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Siedlerchr, sorry I just saw your comment. Thanks for changing the CHANGELOG and approving my changes.

@Siedlerchr Siedlerchr added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Oct 27, 2022
@ThiloteE ThiloteE merged commit 3ca07bf into JabRef:main Oct 28, 2022
This was referenced Oct 28, 2022
Closed
Open
Siedlerchr added a commit to tomazari/jabref that referenced this pull request Nov 1, 2022
@Siedlerchr
Merge remote-tracking branch 'upstream/main' into ISBN-fetcher-for-bo…
3009ed1 
…ok-info.com-JabRef#9145

* upstream/main:
  New Crowdin updates (JabRef#9333)
  Refresh example styles
  Squashed 'buildres/csl/csl-styles/' changes from 4eee79a..13fd98e
  Bump unirest-java from 3.13.11 to 3.13.12 (JabRef#9330)
  Bump checkstyle from 10.3.4 to 10.4 (JabRef#9331)
  Bump gittools/actions from 0.9.14 to 0.9.15 (JabRef#9332)
  Group context menu presents relevant options depending on number of subgroups (JabRef#9286)
  Removed BibTeX file type and included HTML and Markdown types (JabRef#9318)
  Fix issue: Auto-linking files with safe character replacements JabRef#9267 (JabRef#9316)
  Fix for issue 8806: Button highlights doesn't respect rounded corners (JabRef#9320)
  New Crowdin updates (JabRef#9324)
  Update CHANGELOG.md
  Try to relocate listener binding (JabRef#9238)
  Changed the messages after importing unlinked local files to past passive tense. (JabRef#9308)
  Changed the color of found text from red to high contrast  (JabRef#9315)

# Conflicts:
#	CHANGELOG.md
Siedlerchr added a commit to DavidOWade/jabref that referenced this pull request Nov 3, 2022
@Siedlerchr
Merge remote-tracking branch 'upstream/main' into DavidOWade/main
f584ea3 
* upstream/main: (30 commits)
  New translations JabRef_en.properties (German) (JabRef#9336)
  Fix Abbreviation for Escaped Ampersand (JabRef#9288)
  Fix font size preference not updating in preference dialog 8386 (JabRef#9287)
  New Crowdin updates (JabRef#9333)
  Refresh example styles
  Squashed 'buildres/csl/csl-styles/' changes from 4eee79a..13fd98e
  Bump unirest-java from 3.13.11 to 3.13.12 (JabRef#9330)
  Bump checkstyle from 10.3.4 to 10.4 (JabRef#9331)
  Bump gittools/actions from 0.9.14 to 0.9.15 (JabRef#9332)
  Group context menu presents relevant options depending on number of subgroups (JabRef#9286)
  Removed BibTeX file type and included HTML and Markdown types (JabRef#9318)
  Fix issue: Auto-linking files with safe character replacements JabRef#9267 (JabRef#9316)
  Fix for issue 8806: Button highlights doesn't respect rounded corners (JabRef#9320)
  New Crowdin updates (JabRef#9324)
  Update CHANGELOG.md
  Try to relocate listener binding (JabRef#9238)
  Changed the messages after importing unlinked local files to past passive tense. (JabRef#9308)
  Changed the color of found text from red to high contrast  (JabRef#9315)
  New Crowdin updates (JabRef#9317)
  Add skips for MacOS X build (JabRef#9305)
  ...
Siedlerchr added a commit that referenced this pull request Nov 8, 2022
@Siedlerchr
Merge remote-tracking branch 'upstream/main' into 8747-data-field
8464bd6 
* upstream/main:
  New Crowdin updates (#9333)
  Refresh example styles
  Squashed 'buildres/csl/csl-styles/' changes from 4eee79a..13fd98e
  Bump unirest-java from 3.13.11 to 3.13.12 (#9330)
  Bump checkstyle from 10.3.4 to 10.4 (#9331)
  Bump gittools/actions from 0.9.14 to 0.9.15 (#9332)
  Group context menu presents relevant options depending on number of subgroups (#9286)
  Removed BibTeX file type and included HTML and Markdown types (#9318)
  Fix issue: Auto-linking files with safe character replacements #9267 (#9316)
  Fix for issue 8806: Button highlights doesn't respect rounded corners (#9320)
  New Crowdin updates (#9324)
  Update CHANGELOG.md
  Try to relocate listener binding (#9238)
  Changed the messages after importing unlinked local files to past passive tense. (#9308)
  Changed the color of found text from red to high contrast  (#9315)
  New Crowdin updates (#9317)
  Add skips for MacOS X build (#9305)
  New Crowdin updates (#9248)
  Fix for issue 9304 (#9313)

# Conflicts:
#	CHANGELOG.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThiloteE ThiloteE ThiloteE approved these changes

@Siedlerchr Siedlerchr Siedlerchr approved these changes

Assignees
No one assigned
Labels
component: import-load component: ui status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Message after import should be passive
3 participants
@Racheal7 @Siedlerchr @ThiloteE