Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Impossible to delete an Automatic Keyword Group in the UI #9778

Closed
2 tasks done
Siedlerchr opened this issue Apr 18, 2023 · 6 comments · Fixed by #9955
Closed
2 tasks done

Impossible to delete an Automatic Keyword Group in the UI #9778

Siedlerchr opened this issue Apr 18, 2023 · 6 comments · Fixed by #9955
Assignees
@brunaoo
Labels
component: groups component: ui good first issue An issue intended for project-newcomers. Varies in difficulty.

Comments

@Siedlerchr
Copy link
Member

JabRef version

Latest development branch build (please note build date below)

Operating system

macOS

Details on version and operating system

Ventura 13.1.1

Checked with the latest development build

  • I made a backup of my libraries before testing the latest development version.
  • I have tested the latest development version and the problem persists

Steps to reproduce the behaviour

Dev version JabRef 5.10 dab8516

  1. Create a library with some entries
  2. Enable special field priority (see prefs)
  3. Assign some entries the priority 1
  4. Create a new Group with Specified keywords -> Field to group by "priority" . Leave name of the group empty
  5. grafik
  6. Save
  7. Make a right click on the group: Edit shows up twice but no delete
    Uploading grafik.png…

Implementation details:
Check out GroupTreeView.java createContextMenuForGroup

Appendix

...

Log File 
Paste an excerpt of your log file here
@github-project-automation github-project-automation bot moved this to Free to take in Good First Issues Apr 18, 2023
@Siedlerchr Siedlerchr added the good first issue An issue intended for project-newcomers. Varies in difficulty. label Apr 18, 2023
@github-project-automation github-project-automation bot moved this to Normal priority in Prioritization Apr 18, 2023
@Alexandra-Stath
Copy link
Contributor

Hello mr @Siedlerchr,
I am searching for the problem described above while working on a Windows device and I don't seem to come across it. For me the group is able to be removed in the way described. When I try to do it as described above i have to press remove 2 or 3 times and it is deleted, but not from my first try.
Could you describe it again in case I am doing something wrong?
image

@Siedlerchr
Copy link
Member Author

Siedlerchr commented Apr 23, 2023 via email •
edited by koppor
Loading

@Siedlerchr
Copy link
Member Author

And make sure to test the latest development version (main branch)

@DinjerChang
Copy link
Contributor

Hello, I am a new contributor and I would like to work on this issue for uni group course project.
since it's free to take, could you assign to me?

@brunaoo
Copy link
Contributor

brunaoo commented May 11, 2023

Hi, I solved this issue and I'm making the pull request.

brunaoo added a commit to brunaoo/jabref that referenced this issue May 11, 2023
@brunaoo
we fixed an issue is wa delete an Automatic Keyword Group in the UI[J…
4df9b7a 
…abRef#9778](JabRef#9778)
@brunaoo brunaoo mentioned this issue May 11, 2023
Closed
@ThiloteE ThiloteE moved this from Free to take to Reserved in Good First Issues May 11, 2023
@ThiloteE ThiloteE moved this from Reserved to In Progress in Good First Issues May 11, 2023
@ThiloteE ThiloteE moved this from Free to take to In Progress in Candidates for University Projects May 11, 2023
@koppor
Copy link
Member

koppor commented May 12, 2023

@DinjerChang Sorry that this issue was not really free. We assigned a person, but did not update the boards. We did it now.

@ThiloteE ThiloteE moved this from In Progress to Under Review in Candidates for University Projects May 14, 2023
brunaoo added a commit to brunaoo/jabref that referenced this issue May 29, 2023
@brunaoo
we fixed an issue is wa delete an Automatic Keyword Group in the UI[J…
ef03d68 
…abRef#9778](JabRef#9778)
@brunaoo brunaoo mentioned this issue May 29, 2023
Merged
Siedlerchr added a commit that referenced this issue May 30, 2023
@brunaoo @Siedlerchr
Fixed deleting Automatic Keyword Group in the UI (#9955)
424ff1c 
* we fixed an issue is wa delete an Automatic Keyword Group in the UI[#9778](#9778)

* Update CHANGELOG.md

Co-authored-by: Christoph <siedlerkiller@gmail.com>

* we fixed an issue is wa delete an Automatic Keyword Group in the UI[#9778](#9778)

* merge changelog.

* fix commit error

* Update CHANGELOG.md

---------

Co-authored-by: Christoph <siedlerkiller@gmail.com>
@github-project-automation github-project-automation bot moved this from Normal priority to Done in Prioritization May 30, 2023
@github-project-automation github-project-automation bot moved this from In Progress to Done in Good First Issues May 30, 2023
@github-project-automation github-project-automation bot moved this from Under Review to Done in Candidates for University Projects May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brunaoo brunaoo

Labels
component: groups component: ui good first issue An issue intended for project-newcomers. Varies in difficulty.
Projects
Candidates for University Projects
Archived in project
Good First Issues
Archived in project
Prioritization
Archived in project
Milestone
No milestone
5 participants
@Siedlerchr @koppor @brunaoo @Alexandra-Stath @DinjerChang