Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add link to build binary #10049

Merged
merged 3 commits into from
Jul 1, 2023
Merged

Add link to build binary #10049

merged 3 commits into from
Jul 1, 2023

Conversation

koppor
Copy link
Member

@koppor koppor commented Jul 1, 2023

We often write messages like: "The builds should be available in 30mins at builds.jabref.org". With this PR, there will be an automatic message as soon as the binaries got uploaded. In case of another push, there will be a new comment be created (and the old one deleted). This way, the logical order of commits and comments is kept.

Mandatory checks

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@koppor koppor mentioned this pull request Jul 1, 2023
6 tasks
@github-actions
Copy link
Contributor

github-actions bot commented Jul 1, 2023

The build of this PR is available at https://builds.jabref.org/pull/10049/merge.

@koppor
Copy link
Member Author

koppor commented Jul 1, 2023

Before successful deploy at new commit:

image

After:

image

@calixtus calixtus merged commit 214f4e3 into main Jul 1, 2023
@calixtus calixtus deleted the add-download-link branch July 1, 2023 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants