Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement test cases for search #10193

Merged
merged 74 commits into from
Jan 8, 2024
Merged

Conversation

Luggas4you
Copy link
Contributor

@Luggas4you Luggas4you commented Aug 20, 2023

This PR fixes JabRef/jabref-issue-melting-pot#226.

The test cases are based on use cases from this file https://onedrive.live.com/edit.aspx?resid=492A048CAD3FD00B!28014&ithint=file%2cdocx&authkey=!ABIX1j1SIs-unBk.

To-Do:

  • EmptyLibrarySearch
  • UpperAndLowerWordSearch
  • SimpleSingleFieldSearch
  • SimpleMultipleFieldSearch
  • SensitiveWordSearch
  • SensitiveMultipleFieldSearch
  • SimpleRegularExpressionSearch
  • SensitiveRegularExpressionSearch
  • SimplePDFFulltextSearch
  • SimplePDFNoteFulltextSearch
  • SensitivePDFFulltextSearch
  • SensitivePDFNoteFulltextSearch
  • SimpleGroupSearch

Mandatory checks

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@ThiloteE
Copy link
Member

To ease organizational workflows I have linked the pull-request to the issue with syntax as described in https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue

Linking a pull request to an issue using a keyword

You can link a pull request to an issue by using a supported keyword in the pull request's description or in a commit message. The pull request must be on the default branch.

  • close
  • closes
  • closed
  • fix
  • fixes
  • fixed
  • resolve
  • resolves
  • resolved

If you use a keyword to reference a pull request comment in another pull request, the pull requests will be linked. Merging the referencing pull request also closes the referenced pull request.

The syntax for closing keywords depends on whether the issue is in the same repository as the pull request.

@koppor koppor marked this pull request as ready for review January 8, 2024 20:29
calixtus
calixtus previously approved these changes Jan 8, 2024
@calixtus calixtus added this pull request to the merge queue Jan 8, 2024
Merged via the queue into JabRef:main with commit 0c26a55 Jan 8, 2024
18 checks passed
Siedlerchr added a commit that referenced this pull request Jan 12, 2024
* upstream/main: (25 commits)
  Remove remainging "testLogging" (#10769)
  Reuse JUnit 5.7's @DisabledIfEnvironmentVariable (#10768)
  Refactored LibraryTab (#10732)
  Fix annotation (#10766)
  Add initial .git-blame-ignore-revs (#10765)
  Streamline test output (#10762)
  Fix NPE when opening and re-opening a library (#10763)
  Changed default status of 'Automatically open folder of attached files' (#10748)
  Implement test cases for search (#10193)
  Add cites field to bib entries for citation relation (#10752)
  Ignore submodule changes (for normal devs) (#10754)
  Fix line endings
  Bump lycheeverse/lychee-action from 1.8.0 to 1.9.0 (#10760)
  Bump appleboy/ssh-action from 1.0.2 to 1.0.3 (#10761)
  Bump org.apache.lucene:lucene-core from 9.9.0 to 9.9.1 (#10759)
  Bump org.openrewrite.rewrite from 6.5.4 to 6.6.3 (#10758)
  Bump org.glassfish.jersey.containers:jersey-container-grizzly2-http (#10755)
  Bump org.jsoup:jsoup from 1.16.2 to 1.17.2 (#10756)
  Bump org.mockito:mockito-core from 5.7.0 to 5.8.0 (#10757)
  Remove abstract
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants