Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate journal-list.mv on build #10298

Merged
merged 20 commits into from
Sep 3, 2023

Conversation

koppor
Copy link
Member

@koppor koppor commented Sep 3, 2023

This PR removes the binary files journal-lists.mv from the source code. It is generated during the build.

This PR must be merged using a merge commit. Otherwise git subtree won't work.

Refs koppor#360 (which asks for abbreviations also working for conferences)

We now DO NOT include the *.csv files in the repository. We also REMOVED the CSL files, and use git git submodules there, too.

This should reduce our merge conflicts.


Mandatory checks

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

Siedlerchr
Siedlerchr previously approved these changes Sep 3, 2023
@koppor koppor added this pull request to the merge queue Sep 3, 2023
@koppor koppor removed this pull request from the merge queue due to a manual request Sep 3, 2023
@koppor koppor self-assigned this Sep 3, 2023
@koppor koppor marked this pull request as draft September 3, 2023 18:42
@koppor
Copy link
Member Author

koppor commented Sep 3, 2023

Think of

    show-progress: 'false'

for git checkout outs

@koppor
Copy link
Member Author

koppor commented Sep 3, 2023

IDK why the following warning is displayed. I filed an issue at actions/checkout#1446

grafik

@koppor koppor marked this pull request as ready for review September 3, 2023 19:50
@koppor koppor added this pull request to the merge queue Sep 3, 2023
Merged via the queue into JabRef:main with commit cb88d59 Sep 3, 2023
15 of 16 checks passed
@koppor koppor deleted the build-journal-lists-on-deployment branch September 3, 2023 23:57
Siedlerchr added a commit that referenced this pull request Sep 4, 2023
…ustStore

* upstream/main:
  Introduces test http server (#9748)
  Generate journal-list.mv on build (#10298)

# Conflicts:
#	src/main/java/org/jabref/logic/net/ssl/TrustStoreManager.java
@koppor koppor mentioned this pull request Oct 12, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants