Push to external application config #10303

Siedlerchr · 2023-09-03T18:52:14Z

Needs testing for emacs, vim and winEdt and textstudio etc

Mandatory checks

Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
Tests created for changes (if applicable)
Manually tested changed features in running JabRef (always required)
Screenshots added in PR description (for UI changes)
Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

…into pushToExternalConfig * upstream/fix-exception-at-preferences: Fix NPE Fix checkstyle Introduce SelfContainedSaveConfiguration

src/main/java/org/jabref/gui/push/PushToEmacs.java

src/main/java/org/jabref/gui/push/PushToSublimeText.java

src/main/java/org/jabref/gui/push/PushToWinEdt.java

src/main/java/org/jabref/preferences/ExternalApplicationsPreferences.java

github-actions · 2023-09-03T18:55:17Z

Your code currently does not meet JabRef's code guidelines. The tool reviewdog already placed comments on GitHub to indicate the places. See the tab "Files" in you PR. Please carefully follow the setup guide for the codestyle. Afterwards, please run checkstyle locally and fix the issues.

More information on code quality in JabRef is available at https://devdocs.jabref.org/getting-into-the-code/development-strategy.html.

* upstream/main: Use OpenRewrite UseStringReplace (#10299) Add ReplaceStringBuilderWithString (#10302) Apply ShortenFullyQualifiedTypeReferences (#10301) Apply StaticMethodNotFinal (#10300) Apply exit early pattern (#10297) Avoid GH_TOKEN_UPDATE_GRADLE_WRAPPER at refresh-csl-subtrees Update snapcraft.yaml Fix exception when opening preferences (#10294) gnome-42-2204 use gnome 4.2 Use gnome Update base 22

Siedlerchr · 2023-09-03T20:14:26Z

@AdamWysokinski I implemented a first version and I tested it with sublime on mac.
Would be nice if you could test this as well:
https://builds.jabref.org/pull/10303/merge/

I used this pattern, as this works with multiple citations as well:

AdamWysokinski · 2023-09-03T20:42:49Z

Tested with SublimeText on Linux. Works exactly as expected, THANK YOU!

koppor · 2023-09-03T21:43:07Z

TeXStudio:

koppor · 2023-09-03T21:58:43Z

[@key1;@key2]

[@
;@
]

\cite{key1,key2}

Siedlerchr · 2023-09-03T23:23:51Z

[@key1;@key2] is now the new syntax

fix l10n

koppor · 2023-09-04T08:27:52Z

Not working with TeXStudio:

…ation)

…pushToExternalConfig

src/test/java/org/jabref/gui/push/PushToEmacsTest.java

…hToExternalConfig

github-actions · 2023-09-04T13:29:41Z

The build for this PR is no longer available. Please visit https://builds.jabref.org/main/ for the latest build.

koppor and others added 9 commits September 3, 2023 12:09

Introduce SelfContainedSaveConfiguration

6d32f30

prepare adding cite key delimiter and start end chars

de5b38d

Fix checkstyle

e1e244f

Fix NPE

801b77e

Merge remote-tracking branch 'upstream/fix-exception-at-preferences' …

37d078d

…into pushToExternalConfig * upstream/fix-exception-at-preferences: Fix NPE Fix checkstyle Introduce SelfContainedSaveConfiguration

add preferences and text fields

0911ab5

fix sublime escaping

8fd02fc

fix emacs

7767f09

add

6914d6b

github-actions bot reviewed Sep 3, 2023

View reviewed changes

Siedlerchr added 6 commits September 3, 2023 20:56

fix checkstyle

6b87071

fix imports

3de2baf

checkstyle

ebbb5ab

checkstyle the xt

d3d7cd0

Update JabRef_en.properties

9ed8713

calixtus and others added 5 commits September 4, 2023 00:40

Introduced dissectCiteCommand

687dc83

Fixed compile

69500e1

fix cite key and add error logger

8c95de6

fix npe

e448314

fix

cc42d49

Siedlerchr added 2 commits September 4, 2023 01:32

fix index of

8318e86

Update JabRef_en.properties

f6c3276

fix l10n

Siedlerchr enabled auto-merge September 4, 2023 00:05

Siedlerchr added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Sep 4, 2023

Siedlerchr disabled auto-merge September 4, 2023 00:13

Siedlerchr and others added 5 commits September 4, 2023 10:56

fix texstudio insert

57debd2

Shorten localization strings for emacs (and group the pushing localiz…

5e5b09f

…ation)

Rename "couldNotConnect" to "couldNotPush"

690b961

Some debug

26e4b3c

Merge branch 'pushToExternalConfig' of github.com:JabRef/jabref into …

03cd51c

…pushToExternalConfig

github-actions bot reviewed Sep 4, 2023

View reviewed changes

src/test/java/org/jabref/gui/push/PushToEmacsTest.java Outdated Show resolved Hide resolved

src/test/java/org/jabref/gui/push/PushToEmacsTest.java Show resolved Hide resolved

src/test/java/org/jabref/gui/push/PushToEmacsTest.java Show resolved Hide resolved

koppor and others added 10 commits September 4, 2023 11:48

New variable pushToApplicationPreferences

04a266d

Works on Windows

628ee5d

Use "replace" instead of "replaceAll"

48555e4

Shorten messages for Vim

ce7b0a7

Add logger to Vim execution, too

147b744

Style: LOGGER first

bee8eac

Modified test for linux

d3eca8b

Merge remote-tracking branch 'upstream/pushToExternalConfig' into pus…

9d358e4

…hToExternalConfig

Make emacs test "portable"

fc0843e

Fix localization language

6bea642

Siedlerchr enabled auto-merge September 4, 2023 13:33

koppor approved these changes Sep 4, 2023

View reviewed changes

Siedlerchr added this pull request to the merge queue Sep 4, 2023

Merged via the queue into main with commit eaabae5 Sep 4, 2023
13 checks passed

Siedlerchr deleted the pushToExternalConfig branch September 4, 2023 14:01

koppor mentioned this pull request Oct 24, 2023

The command "Push entries to external application" adds a "null" prefix and suffix to an existing Citationkey in LaTeX. #10568

Closed

2 tasks

koppor mentioned this pull request Nov 2, 2023

Copy cite command should respect preferences #10615

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Push to external application config #10303

Push to external application config #10303

Siedlerchr commented Sep 3, 2023 •

edited

Loading

github-actions bot commented Sep 3, 2023

Siedlerchr commented Sep 3, 2023

AdamWysokinski commented Sep 3, 2023

koppor commented Sep 3, 2023

koppor commented Sep 3, 2023

Siedlerchr commented Sep 3, 2023

koppor commented Sep 4, 2023

github-actions bot commented Sep 4, 2023 •

edited

Loading

Push to external application config #10303

Push to external application config #10303

Conversation

Siedlerchr commented Sep 3, 2023 • edited Loading

Mandatory checks

github-actions bot commented Sep 3, 2023

Siedlerchr commented Sep 3, 2023

AdamWysokinski commented Sep 3, 2023

koppor commented Sep 3, 2023

koppor commented Sep 3, 2023

Siedlerchr commented Sep 3, 2023

koppor commented Sep 4, 2023

github-actions bot commented Sep 4, 2023 • edited Loading

Siedlerchr commented Sep 3, 2023 •

edited

Loading

github-actions bot commented Sep 4, 2023 •

edited

Loading