Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Copy browser extension files for mac #10340

Merged
merged 5 commits into from
Sep 10, 2023
Merged

Copy browser extension files for mac #10340

merged 5 commits into from
Sep 10, 2023

Conversation

Siedlerchr
Copy link
Member

@Siedlerchr Siedlerchr commented Sep 6, 2023 •
edited
Loading

Fixes #10308

I found out about "add-content", however that only copies to the root dir, so I adjusted the scripts:
Need testing if the python path still works

grafik

Mandatory checks

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@Siedlerchr
Copy link
Member Author

Siedlerchr commented Sep 7, 2023 •
edited
Loading

  • run on arm with notarization and test if the browser extension works

@koppor koppor mentioned this pull request Sep 7, 2023
Closed
6 tasks
@Siedlerchr
Merge remote-tracking branch 'upstream/main' into addAddContentToImage
0337872 
* upstream/main:
  Replacement localization (#10358)
  Add workaround for IDEA-317606
  Fix CHANGELOG.md linting issues (#10351)
  fix afterburner
  checkstyle
  add changelog
  Fix NPE when adding new aux group
  Add "--verbose" to MV generator (#10347)
  Fix dependencies (#10326)
  Add new openrewrite rules (#10342)
  New Crowdin updates (#10344)
  Rework duplicate checker tests (#10341)
@Siedlerchr
fix path for jabref detection
3a84da6
@Siedlerchr
add changelog entry
62865f1
@Siedlerchr
specify pgk
58415a0
@Siedlerchr Siedlerchr added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Sep 9, 2023
@Siedlerchr
Copy link
Member Author

ARM build https://builds.jabref.org/addAddContentToImage/

@Siedlerchr Siedlerchr mentioned this pull request Sep 9, 2023
Merged
6 tasks
@github-actions
Copy link
Contributor

github-actions bot commented Sep 9, 2023 •
edited
Loading

The build for this PR is no longer available. Please visit https://builds.jabref.org/main/ for the latest build.

calixtus
calixtus approved these changes Sep 10, 2023
View reviewed changes
Copy link
Member

@calixtus calixtus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As there are no build fails, there are no obvious errors and you are the mac expert, I gonna just approve this.

@calixtus calixtus added this pull request to the merge queue Sep 10, 2023
Merged via the queue into main with commit ed543e9 Sep 10, 2023
@calixtus calixtus deleted the addAddContentToImage branch September 10, 2023 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calixtus calixtus calixtus approved these changes

Assignees
No one assigned
Labels
status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing jabrefHost.py on 5.10/5.11 causing the browser extension to fail
2 participants
@Siedlerchr @calixtus