Try to fix ioob for selected entries #10389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThiloteE
reviewed
Sep 16, 2023
|
I tried this PR. In its current state does NOT fix #8719 |
|
|
note, that thilo's exception is more related to #10379 |
koppor
reviewed
Sep 17, 2023
| @@ -517,15 +518,14 @@ private void createMainTable() { | |||
| entryTypesManager, | |||
| taskExecutor, | |||
| fileUpdateMonitor); | |||
|
|
|||
| // conntent binding does not work as it won't trigger the needsEntries checker | |||
There was a problem hiding this comment.
I did not quite get the reference to needsEntries checker. Thus, I tried to find it:
Suggested change
| // conntent binding does not work as it won't trigger the needsEntries checker | |
| // content binding does not work as it does not trigger the ManageKeywordsAction#needsEntriesSelected checker |
There was a problem hiding this comment.
I added a clarification, ActionHelper#needsEntriesSelected - enables or disables the menu items
koppor
reviewed
Sep 17, 2023
|
Your code currently does not meet JabRef's code guidelines. The tool reviewdog already placed comments on GitHub to indicate the places. See the tab "Files" in you PR. Please carefully follow the setup guide for the codestyle. Afterwards, please run checkstyle locally and fix the issues. More information on code quality in JabRef is available at https://devdocs.jabref.org/getting-into-the-code/development-strategy.html. |
Co-authored-by: Oliver Kopp <kopp.dev@gmail.com>
koppor
approved these changes
Sep 17, 2023
|
Note that this DOES NOT FIX Thilo's reported exception. |
Open
2 tasks
|
The build for this PR is no longer available. Please visit https://builds.jabref.org/main/ for the latest build. |
|
+1 for follow-up. Code looks better than before, therefore merging. |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #10373
Use changed list from the listener
Mandatory checks
CHANGELOG.mddescribed in a way that is understandable for the average user (if applicable)