Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove outdated parts of code-howtos/IntelliJ (and move good parts) #10400

Merged
merged 5 commits into from
Sep 19, 2023

Conversation

koppor
Copy link
Member

@koppor koppor commented Sep 19, 2023

I found the "## Other notes on IntelliJ" part in docs/code-howtos/IntelliJ.md. They became obsolete in #10323. There, I forgot about those parts.

Mandatory checks

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

Siedlerchr
Siedlerchr previously approved these changes Sep 19, 2023
@koppor koppor marked this pull request as draft September 19, 2023 08:21
@koppor
Copy link
Member Author

koppor commented Sep 19, 2023

I added https://stackoverflow.com/a/36570524/873282 as a howto.

Checked the rendering using Docker (explained at https://github.com/JabRef/jabref/blob/main/docs/README.md)

@koppor koppor marked this pull request as ready for review September 19, 2023 09:28
@github-actions
Copy link
Contributor

github-actions bot commented Sep 19, 2023

The build for this PR is no longer available. Please visit https://builds.jabref.org/main/ for the latest build.

@koppor koppor added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Sep 19, 2023
@koppor koppor removed the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Sep 19, 2023
@koppor koppor merged commit 516eaa1 into main Sep 19, 2023
17 of 19 checks passed
@koppor koppor deleted the refine-intellij-howto branch September 19, 2023 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants