Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Type Bachelor's Thesis to EntryType Thesis for Biblatex References #10497

Merged
merged 3 commits into from
Oct 21, 2023

Conversation

cmgoodall
Copy link
Contributor

@cmgoodall cmgoodall commented Oct 15, 2023

I have added the Type 'Bachelor's Thesis' to the dropdown of Types when choosing the EntryType of Thesis.

resolves #10029

Mandatory checks

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

Screenshot of Change

Screenshot 2023-10-16 at 8 02 09 am

* Added 'Bachelor's Thesis' (bathesis) to TypeEditorViewModel.java
* Added change to CHANGELOG.md
* Added line to JabRef_en.properties due to use of Localization in TypeEditorViewModel.java
@cmgoodall cmgoodall marked this pull request as ready for review October 15, 2023 21:32
@Siedlerchr Siedlerchr added this to the 5.12 milestone Oct 16, 2023
@Siedlerchr Siedlerchr added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Oct 21, 2023
@Siedlerchr
Copy link
Member

so far it looks good, we just need to recheck if the preferences error happens again or can happen again.

@cmgoodall
Copy link
Contributor Author

I've tried to recreate the issue however, have been unsuccessful. I think the issue might have stemmed from the fact I had JabRef preferences saved from the actual application and they might have been messing with it? I'm not 100% sure though. I've looked at all the files you've recommended and cannot see anything that is causing the error.

@Siedlerchr
Copy link
Member

I also tested it locally back and forth with an older version of JabRef and could not reproduce the issue, so I think it's fine

@Siedlerchr Siedlerchr removed this from the 5.12 milestone Oct 21, 2023
@Siedlerchr Siedlerchr added this pull request to the merge queue Oct 21, 2023
@Siedlerchr
Copy link
Member

No further actions necessary, the build will be automatically merged now.

Merged via the queue into JabRef:main with commit d6fd106 Oct 21, 2023
16 checks passed
@koppor
Copy link
Member

koppor commented Oct 24, 2023

@cmgoodall I don't see an issue at the user-documentation. Can you provide the link? https://github.com/JabRef/user-documentation/issues?q=is%3Aissue+is%3Aopen+sort%3Aupdated-desc

@cmgoodall
Copy link
Contributor Author

Hi @koppor. Apologies, I didn't realise I was required to do this. I have just raised an issue

JabRef/user-documentation#472

@k3KAW8Pnf7mkmdSMPHz27
Copy link
Member

k3KAW8Pnf7mkmdSMPHz27 commented Oct 28, 2023

@cmgoodall I think @koppor is referring to

that is, are there any parts of the user documentation that should be updated due to this PR, and if so, which parts?
From a generic open-source point of view, JabRef/user-documentation#472 is not easily actionable for someone not familiar with this issue and PR (i.e., me 😅) because they are unlikely to be familiar with the thesis EntryType. Is there more context you can add to the documentation issue, create a PR, or briefly argue why you don't believe it to be necessary/useful? When I quickly search for phdthesis in our documentation, I don't find anything I believe needs to be updated, barring perhaps the field mapping.

@koppor
Copy link
Member

koppor commented Oct 28, 2023

When I quickly search for phdthesis in our documentation,

Some spontaneous ideas: Maybe a new screenshot of the entry editor? Maybe pointing the user to a place in the biblatex documentation where this feature is described?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Type option for Bachelor's thesis
5 participants