-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Type Bachelor's Thesis to EntryType Thesis for Biblatex References #10497
Conversation
* Added 'Bachelor's Thesis' (bathesis) to TypeEditorViewModel.java * Added change to CHANGELOG.md * Added line to JabRef_en.properties due to use of Localization in TypeEditorViewModel.java
so far it looks good, we just need to recheck if the preferences error happens again or can happen again. |
I've tried to recreate the issue however, have been unsuccessful. I think the issue might have stemmed from the fact I had JabRef preferences saved from the actual application and they might have been messing with it? I'm not 100% sure though. I've looked at all the files you've recommended and cannot see anything that is causing the error. |
I also tested it locally back and forth with an older version of JabRef and could not reproduce the issue, so I think it's fine |
No further actions necessary, the build will be automatically merged now. |
@cmgoodall I don't see an issue at the user-documentation. Can you provide the link? https://github.com/JabRef/user-documentation/issues?q=is%3Aissue+is%3Aopen+sort%3Aupdated-desc |
Hi @koppor. Apologies, I didn't realise I was required to do this. I have just raised an issue |
@cmgoodall I think @koppor is referring to
that is, are there any parts of the user documentation that should be updated due to this PR, and if so, which parts? |
Some spontaneous ideas: Maybe a new screenshot of the entry editor? Maybe pointing the user to a place in the biblatex documentation where this feature is described? |
I have added the Type 'Bachelor's Thesis' to the dropdown of Types when choosing the EntryType of Thesis.
resolves #10029
Mandatory checks
CHANGELOG.md
described in a way that is understandable for the average user (if applicable)Screenshot of Change