Added Fetcher for ISIDORE #10518

u7492883 · 2023-10-18T11:38:20Z

Added a fetcher for the webside ISIDORE, (https://isidore.science/). The fetcher will get all the fields that it can find and will convert them into a BibEntry.
Fixes #10423.

Mandatory checks

Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
Tests created for changes (if applicable)
Manually tested changed features in running JabRef (always required)
Screenshots added in PR description (for UI changes)
Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

Created a fetcher that would automatically fill referencing information from ISIDORE. Unfortunately the XML files are not always formatted the same way which increased the number of methods in this fetcher compared to the others.

Added the ISIDOREFetcher to the list of WebFetchers, on line 149.

Added tests for the ISIDORE fetcher.

Fixed case where doi would not be added correctly.

into fix-for-issue-10423

Added ISIDORE's privacy policy link to PRIVACY.md.

src/main/java/org/jabref/logic/importer/fetcher/ISIDOREFetcher.java

koppor

Thank you for your work. Thank you also for putting test cases.

Comments for improvement attached.

src/main/java/org/jabref/logic/importer/fetcher/ISIDOREFetcher.java

src/test/java/org/jabref/logic/importer/fetcher/ISIDOREFetcherTest.java

…s) and fixed typo.

koppor

Thank you for continuing working.

Some code comments attached to level-up your coding skills!

src/main/java/org/jabref/logic/importer/fetcher/ISIDOREFetcher.java

src/test/java/org/jabref/logic/importer/fetcher/ISIDOREFetcherTest.java

src/main/java/org/jabref/logic/importer/fetcher/ISIDOREFetcher.java

…om pull request.

into fix-for-issue-10423

Siedlerchr · 2023-11-03T19:25:53Z

Current status: Isidore science seems buggy we always get an empty input stream back.

Co-authored-by: Oliver Kopp <kopp.dev@gmail.com>

koppor · 2023-12-26T22:56:03Z

We think, the API as of today returns and empty result if too many words are requested.

koppor · 2024-01-09T01:10:14Z

The API is a PITA. If too much word are queried, no results are returned.

In case there is a real user need to include this API, the PR is "finished". It at least returns some results for less keywords.

Tal Shy-Tielen and others added 15 commits October 17, 2023 19:30

ADD ISIDOREFetcher

fb2222e

Created a fetcher that would automatically fill referencing information from ISIDORE. Unfortunately the XML files are not always formatted the same way which increased the number of methods in this fetcher compared to the others.

ADD ISIDOREFetcher to WebFetchers

7d65239

Added the ISIDOREFetcher to the list of WebFetchers, on line 149.

Merge branch 'JabRef:main' into fix-for-issue-10423

0f87aed

Merge branch 'JabRef:main' into fix-for-issue-10423

6d02f06

ADD ISIDOREFetcherTest.java

25e4985

Added tests for the ISIDORE fetcher.

FIX ISIDOREFetcher.java

060b388

Fixed case where doi would not be added correctly.

Merge branch 'fix-for-issue-10423' of https://github.com/u7492883/jabref

3037d9a

into fix-for-issue-10423

ADD ISIDORE privacy policy

ea6988e

Added ISIDORE's privacy policy link to PRIVACY.md.

ADD ISIDORE fetcher to CHANGELOG.md

403bf06

ADD issue number before link.

6d286fe

REMOVE stacktrace message from ISIDOREFetcher.java

e50b370

FIX static analysis issue with ISIDOREFetcher.java.

39496eb

REMOVED inverted booleans

664a933

FIX using replace instead of replaceALL

bcd405c

FIX string equals avoids null

c08beb0

Siedlerchr reviewed Oct 19, 2023

View reviewed changes

src/main/java/org/jabref/logic/importer/fetcher/ISIDOREFetcher.java Outdated Show resolved Hide resolved

u7492883 and others added 2 commits October 20, 2023 11:47

Merge branch 'JabRef:main' into fix-for-issue-10423

38b9d33

EDIT moved parser creation into constructor.

48def73

koppor requested changes Oct 20, 2023

View reviewed changes

Tal Shy-Tielen and others added 5 commits October 20, 2023 12:19

FIX added constant values and removed abstract (due to copyright risk…

b246a0d

…s) and fixed typo.

FIX made ISIDOREFetcherTest.java more readable.

86e4ba4

EDIT use //s instead of looking for multiple spaces

ca69df7

ADD comment about publisher format.

81c2172

Merge branch 'main' into fix-for-issue-10423

8f45b03

koppor requested changes Oct 21, 2023

View reviewed changes

Siedlerchr reviewed Oct 21, 2023

View reviewed changes

src/main/java/org/jabref/logic/importer/fetcher/ISIDOREFetcher.java Outdated Show resolved Hide resolved

Tal Shy-Tielen added 3 commits October 22, 2023 12:14

EDIT made test cases more readable and intuitive based on comments fr…

e15a3aa

…om pull request.

EDIT using StringJoiner and fixed exceptions based on comments.

0ca60b9

Merge branch 'fix-for-issue-10423' of https://github.com/u7492883/jabref

4dacce8

into fix-for-issue-10423

ThiloteE added the fetcher label Oct 22, 2023

fck fetcher

5c09c36

Siedlerchr and others added 5 commits November 4, 2023 20:19

add accept header

cd6d630

Merge branch 'main' into fix-for-issue-10423

8e3eb37

fix fetcher

50e4205

Co-authored-by: Oliver Kopp <kopp.dev@gmail.com>

Fix checkstyle

d00eeb1

Adapt test to include new fetcher

e96cfef

koppor added 6 commits December 26, 2023 23:58

Fix checkstyle issues

b8c8f68

Fix support for querying for authors

92cf060

remove duplicate test

87f17bc

Merge branch 'main' into fix-for-issue-10423

5b04053

Add workaround of fielded terms.

d4d08e0

More modern "Word" class

b71ef06

openRewrite

baa4038

koppor added the status: devcall label Jan 11, 2024

u7492883 closed this Jan 11, 2024

Siedlerchr reopened this Jan 12, 2024

koppor removed the status: devcall label Jan 15, 2024

Merge branch 'main' into fix-for-issue-10423

42bac2b

koppor enabled auto-merge January 15, 2024 20:22

koppor previously approved these changes Jan 15, 2024

View reviewed changes

koppor added 2 commits January 16, 2024 01:10

Merge branch 'main' into fix-for-issue-10423

a0dfb2d

Fix checkstyle

247ec3e

koppor dismissed their stale review via 247ec3e January 16, 2024 00:13

koppor approved these changes Jan 16, 2024

View reviewed changes

koppor added this pull request to the merge queue Jan 16, 2024

Merged via the queue into JabRef:main with commit 37a45e0 Jan 16, 2024
18 of 19 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added Fetcher for ISIDORE #10518

Added Fetcher for ISIDORE #10518

u7492883 commented Oct 18, 2023

koppor left a comment

koppor left a comment

Siedlerchr commented Nov 3, 2023

koppor commented Dec 26, 2023

koppor commented Jan 9, 2024

Added Fetcher for ISIDORE #10518

Added Fetcher for ISIDORE #10518

Conversation

u7492883 commented Oct 18, 2023

Mandatory checks

koppor left a comment

Choose a reason for hiding this comment

koppor left a comment

Choose a reason for hiding this comment

Siedlerchr commented Nov 3, 2023

koppor commented Dec 26, 2023

koppor commented Jan 9, 2024