Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable binary building on forks #10576

Closed
wants to merge 1 commit into from
Closed

Enable binary building on forks #10576

wants to merge 1 commit into from

Conversation

koppor
Copy link
Member

@koppor koppor commented Oct 24, 2023

A build at a fork should also provide binaries. This PR enables this. Tried at koppor#660 - and it worked.

image

macOS contains a folder (JabRef.app) instead of a zip, but I think: better than nothing ^^

Follow-up to #10574

Mandatory checks

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 24, 2023

The build for this PR is no longer available. Please visit https://builds.jabref.org/main/ for the latest build.

@Siedlerchr
Copy link
Member

Please zip at least the mac app. The folder does not help and you cannot download it

@Siedlerchr
Copy link
Member

I don't like the idea of building binary files for forks. There are so many wip prs that never get finished and Will occupy disk space.

@Siedlerchr Siedlerchr closed this Oct 25, 2023
@koppor
Copy link
Member Author

koppor commented Oct 25, 2023

I don't like the idea of building binary files for forks. There are so many wip prs that never get finished and Will occupy disk space.

This PR stores them on GitHub, not at our server. - They are kept on GitHub for 90 days. (See https://docs.github.com/en/organizations/managing-organization-settings/configuring-the-retention-period-for-github-actions-artifacts-and-logs-in-your-organization).

If we want to save space for GitHub, we could change the setting to 3 days?

@koppor
Copy link
Member Author

koppor commented Oct 25, 2023

Please zip at least the mac app. The folder does not help

Didn't we remove the zipping in our build scripts somehow? I forgot :p

and you cannot download it

I don't understand. One can click on "JabRef-macos-latest" and you get that thing containing that folder.

@koppor
Copy link
Member Author

koppor commented Oct 28, 2023

For #10521, I would have needed a binary build to send the binary to MLEP for testing.

@koppor koppor deleted the build-binaries branch September 26, 2024 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants