Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactored LibraryTab #10732

Merged
merged 21 commits into from
Jan 11, 2024
Merged

Refactored LibraryTab #10732

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
9fbac6a
Removed code duplication
calixtus Dec 26, 2023
c6e5373
Moved LibraryTab to its own package
calixtus Dec 26, 2023
30ddc7e
Moved call to LibraryTab::cleanup to libraryTab itself
calixtus Dec 26, 2023
eab3616
Refactored BasePanelMode to LibraryTab private
calixtus Dec 26, 2023
727d03b
Refactored closing library
calixtus Dec 31, 2023
a3c911a
Extracted dnd methods
calixtus Dec 31, 2023
4b4e2ed
Merge remote-tracking branch 'upstream/main' into cleanup-librarytab
calixtus Dec 31, 2023
f32e475
Merge remote-tracking branch 'upstream/main' into cleanup-librarytab
calixtus Jan 6, 2024
119052d
Fixed merge errors
calixtus Jan 6, 2024
f235724
Fixed closing issues
calixtus Jan 9, 2024
7bd98c3
Fixed entry editor showing
calixtus Jan 9, 2024
3abc4a8
Reverted c6e53731
calixtus Jan 9, 2024
21ca846
Fixed quitting, removed unnecessary conversion between string and path
calixtus Jan 9, 2024
98b2d2c
Reduced scope of UpdateTimestampListener again
calixtus Jan 9, 2024
5b4823f
Reduced scope of some methods and fixed concurrency issue after prefs…
calixtus Jan 9, 2024
5419eb3
Fixed test
calixtus Jan 10, 2024
6e00c6f
Fixed localization issue
calixtus Jan 10, 2024
9bf7047
Merge remote-tracking branch 'upstream/main' into cleanup-librarytab
calixtus Jan 10, 2024
678f829
Fixed merge errors
calixtus Jan 10, 2024
9840953
Fixed review comments
calixtus Jan 10, 2024
374a969
Fixed small concurrency errors and nullptr
calixtus Jan 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 0 additions & 11 deletions src/main/java/org/jabref/gui/BasePanelMode.java
View file
Open in desktop

This file was deleted.

386 changes: 146 additions & 240 deletions src/main/java/org/jabref/gui/JabRefFrame.java
View file
Open in desktop

Large diffs are not rendered by default.

6 changes: 2 additions & 4 deletions src/main/java/org/jabref/gui/JabRefGUI.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
import java.util.ArrayList;
import java.util.List;
import java.util.Optional;
import java.util.stream.Collectors;

import javafx.application.Platform;
import javafx.scene.Scene;
Expand Down Expand Up @@ -320,13 +319,12 @@ private boolean isWindowPositionOutOfBounds() {
}

private void openLastEditedDatabases() {
List<String> lastFiles = preferencesService.getGuiPreferences().getLastFilesOpened();
List<Path> lastFiles = preferencesService.getGuiPreferences().getLastFilesOpened();
if (lastFiles.isEmpty()) {
return;
}

List<Path> filesToOpen = lastFiles.stream().map(Path::of).collect(Collectors.toList());
getMainFrame().getOpenDatabaseAction().openFiles(filesToOpen);
getMainFrame().getOpenDatabaseAction().openFiles(lastFiles);
}

public static JabRefFrame getMainFrame() {
Expand Down
Loading