Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add refresh button for LaTeX citations. #10901

Merged
merged 5 commits into from
Feb 21, 2024
Merged

Add refresh button for LaTeX citations. #10901

merged 5 commits into from
Feb 21, 2024

Conversation

AbdAlRahmanGad
Copy link
Contributor

@AbdAlRahmanGad AbdAlRahmanGad commented Feb 21, 2024 •
edited by Siedlerchr
Loading

Fixes #10584.

Screenshot 2024-02-21 at 10 33 22 AM
  • As for developer's documentation I don't think anything should change.
  • As for the user's documentation I think the screenshots and GIFs here should be replaced to include the new button. Should I make an issue in the user-documentation repository after the pull is merged?

Mandatory checks

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

Siedlerchr
Siedlerchr reviewed Feb 21, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@Siedlerchr
Copy link
Member

Codewise looks good so far, you have just one failing Unit test, some missing localization.
https://devdocs.jabref.org/code-howtos/localization.html

@Siedlerchr Siedlerchr added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Feb 21, 2024
@AbdAlRahmanGad
Copy link
Contributor Author

Ok, I'll fix it now.

@koppor koppor added this pull request to the merge queue Feb 21, 2024
Merged via the queue into JabRef:main with commit 4e9f49f Feb 21, 2024
20 checks passed
Siedlerchr added a commit to shawn-jj/jabref that referenced this pull request Feb 26, 2024
@Siedlerchr
Merge remote-tracking branch 'upstream/main' into fix-for-issue-10509
cef4f9c 
* upstream/main: (22 commits)
  Bump com.github.andygoossens.modernizer from 1.9.0 to 1.9.2 (JabRef#10922)
  Bump com.dlsc.gemsfx:gemsfx from 1.97.0 to 2.0.3 (JabRef#10923)
  Bump org.apache.logging.log4j:log4j-to-slf4j from 2.22.1 to 2.23.0 (JabRef#10921)
  Added missing changelog entry for JabRef#10912
  Change the popup to enter types to the combo box for custom entry types (JabRef#10912)
  Add JDK EA build (JabRef#10904)
  Fix Broken Links (JabRef#10899)
  Add HTML2MD conversion to abstract and comment fields (JabRef#10896)
  docs: Fixed URLs and corrected typos (JabRef#10900)
  Add refresh button for LaTeX citations. (JabRef#10901)
  Farewell btut 👋 (JabRef#10905)
  Fix: About OOError, Alternatives section not visible (JabRef#10902)
  Update code-quality.md
  Fix documentation issues: Sourcegraph URL and method name (JabRef#10898)
  Removed mainapplication layer (JabRef#10895)
  Update check-links.yml (JabRef#10897)
  [WIP] Adds the ability to specify [camelN] as a title-related field marker for citation key generation (JabRef#10772)
  Bump com.dlsc.gemsfx:gemsfx from 1.92.0 to 1.97.0 (JabRef#10894)
  Bump org.openrewrite.recipe:rewrite-recipe-bom from 2.6.3 to 2.6.4 (JabRef#10892)
  Bump org.junit.platform:junit-platform-launcher from 1.10.1 to 1.10.2 (JabRef#10893)
  ...

# Conflicts:
#	src/main/java/org/jabref/gui/desktop/os/NativeDesktop.java
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koppor koppor koppor approved these changes

@Siedlerchr Siedlerchr Siedlerchr approved these changes

Assignees
No one assigned
Labels
status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refresh button for LaTeX citations
3 participants
@AbdAlRahmanGad @Siedlerchr @koppor