fix for Library is marked as unsaved (*) after accepting changes from the file #11046
Conversation
fix for Library is marked as unsaved (*) after accepting changes from the file
…thdas/jabref into bugfix/unsavedlibrary-11027
changelog update
|
I am not sure if just saving is the right approach. JabRef has an autosave feature, which is offering "similar" functionality. The original issue was: "even though it should match exactly the contents of the file saved to disk". I am clarifying the requirement at #11027 (comment). |
| @@ -910,7 +910,8 @@ public void resetChangeMonitor() { | |||
| taskExecutor, | |||
| dialogService, | |||
| preferencesService, | |||
| databaseNotificationPane)); | |||
| databaseNotificationPane, | |||
| this)); | |||
There was a problem hiding this comment.
I think, better org.jabref.gui.StateManager#activeTabProperty should be used inside the code instead of passing down the tab.
| @@ -88,12 +91,13 @@ private static Optional<ParserResult> showReviewBackupDialog( | |||
| List<DatabaseChange> changes = DatabaseChangeList.compareAndGetChanges(originalDatabase, backupDatabase, changeResolverFactory); | |||
| DatabaseChangesResolverDialog reviewBackupDialog = new DatabaseChangesResolverDialog( | |||
| changes, | |||
| originalDatabase, "Review Backup" | |||
| originalDatabase, "Review Backup", | |||
| libraryTab | |||
There was a problem hiding this comment.
Nono, there should be no save for restored backups. Please do not overwrite backups.
|
@amrithdas The discussion turned out that it is only about the asterisk marker, NOT about saving. Saving may lead to issues, thus this should be kept separate. Just try to change the logic that the library is not changed if all external changes were accepted. |
|
@koppor so only asterisk needs to be removed when external changes are accepted? |
Library will be saved along with accepting external changes in the bibTex file.
modified the code to save library upon clicking accept button in the review changes dialog box.
Closes #11027
Mandatory checks
CHANGELOG.mddescribed in a way that is understandable for the average user (if applicable)